Fix miscellaneous bugs and miscellaneous improvements#22
Conversation
…but when get_products(system) is not a subset of keys(id_to_color_map). This case did not expand id_to_color_map correctly.
…rogen and add a colors for the HeatLT and HeatHT resources.
…for countries just above the ocean layer.
…ates are not provided).
Zetison
added
bug
JulStraus
left a comment
JulStraus
left a comment
There was a problem hiding this comment.
Looks generally speaking good. Please take a look at the suggestion for the descriptive names.
Have you tested that it works now with length(get_products(system)) == length(id_to_color_map)? If so, I think it would be good to have that as well included in the test setup.
src/descriptive_names.yml
Outdated
| CycleLife: | ||
| stack_cost: "Relative cost for replacing a battery stack" | ||
|
|
||
| ## EnergyModelsHeat |
There was a problem hiding this comment.
No ThermalEnergyStorage? Probably ok with the base as the other parameters are no TimeProfiles
There was a problem hiding this comment.
I will add ThermalEnergyStorage.
There was a problem hiding this comment.
Please just check that it is necessary. Based on my understanding, it should not be.
Co-authored-by: Julian Straus <104911227+JulStraus@users.noreply.github.com>
…EnergyModelsGUI.jl into fix/examples_bug_and_misc
Zetison
left a comment
Zetison
left a comment
There was a problem hiding this comment.
Corrections to come in next push.
src/descriptive_names.yml
Outdated
| CycleLife: | ||
| stack_cost: "Relative cost for replacing a battery stack" | ||
|
|
||
| ## EnergyModelsHeat |
There was a problem hiding this comment.
I will add ThermalEnergyStorage.
I suggest adding this test later to get this PR registered asap. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
JulStraus
left a comment
JulStraus
left a comment
There was a problem hiding this comment.
Looks ok to me. I would suggest squash and merge. We can at a latter point also consider to remove all fields that are not relevant in descriptive_names.yml as we currently still have their a mix of fields included.
3 participants
This PR makes the setup of tailored
id_to_color_mapmore robust, adds a missing docstring description of the optional argumentcase_namein theGUI-function and adds the missing EnergyModelsGUI package from the Project.toml file in the examples folder. Additionally, the following is adjusted and improved:EnergyModelsHeatandEnergyModelsHydrogen, and added colors for theHeatLTandHeatHTresources.