Conversation
- utils function necessary for inheritance - changes to update_descriptive_names! to add inheritance step - Changes to descriptive_names.yml; removing redundant descriptive names and adding descriptive names to supertypes.
- utils function necessary for inheritance - changes to update_descriptive_names! to add inheritance step - Changes to descriptive_names.yml; removing redundant descriptive names and adding descriptive names to supertypes.
- utils function necessary for inheritance - changes to update_descriptive_names! to add inheritance step - Changes to descriptive_names.yml; removing redundant descriptive names and adding descriptive names to supertypes.
Zetison
force-pushed
the
feat/inherit_desc_names
branch
from
742299d to
56621a9
Compare
Zetison
requested changes
Nov 14, 2025
Collaborator
Zetison
left a comment
Zetison
left a comment
There was a problem hiding this comment.
This PR is an convenient, elegant and important enhancement of the handling of descriptive_names! It simplifies further extensions and removes redundant descriptions in the old src/descriptive_names.yml file.
Consider if you can find solution to the issue raised and other suggestions I have added.
Co-authored-by: Jon Vegard Venås <jonvegard.venas@sintef.no>
…delsX/EnergyModelsGUI.jl into feat/inherit_desc_names
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Collaborator
|
Fixes #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #31