[$250 - WAITING FOR PAYMENT] IOS - Submit expense - Next button not fully visible after returning online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the app and log in
2. Disable internet connection
3. Tap FAB > Submit expense
4. Select any tab, e.g. Distance (the same for manual and scan request)
5. Return online

Expected Result:

The Next button is fully visible

Actual Result:

Only the top of the Next button is visible. It is reproducible with Manual and Scan tabs

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6474132_1715107077940.IMG_6781.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1a3e2d4eb573fb6
• Upwork Job ID: 1788618114597507072
• Last Price Increase: 2024-08-08
• Automatic offers:
• QichenZhu | Contributor | 103491055

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Next button not fully visible after returning online

What is the root cause of that problem?

StepScreenWrapper by default adds safeAreaPaddingBottom that overlaps the bottom button in request pages

What changes do you think we should make in order to solve the problem?

We will pass includeSafeAreaPaddingBottom={false} to StepScreenWrapper in affected pages in IOU request steps.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1a3e2d4eb573fb6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Native small screens - Submit expense - Next button not fully visible after returning online

What is the root cause of that problem?

Currently when we are using "small screens" (or native screens) the MapView try to use the space available to render itself, this space is calculated by the ScreenWrapper component based in the initialHeight (in this case) and the children components.

The issue is for native screens when we render the map the first time (when online) we take the all available space, but then when we go offline we show/render an offline indicator, this makes the available height reduced (so we see the map pending indicator a bit short than the map), then when we go online the map try to recover its original height (but now we have less height space due the offline indicators) and move down the next button.

What changes do you think we should make in order to solve the problem?

We should set the height of each container with percents to fix this issue in IOURequestStepDistance and also in MoneyRequestAmountForm, to keep next button aligned.

The changes should be in

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 437 in 66b4072

<View style={styles.flex1}>

<View style={Platform.OS === 'web' ? styles.flex1 : [styles.dBlock, styles.w100, {height: '85%'}]}>

And in

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 454 in 66b4072

<View style={[styles.w100, styles.pt2]}>

<View style={(styles.dBlock, styles.w100, styles.pt2, Platform.OS !== 'web' ? {height: '15%'} : {})}>

Also in

App/src/pages/iou/MoneyRequestAmountForm.tsx

Lines 302 to 306 in 66b4072

	<View
	onMouseDown={(event) => onMouseDown(event, [NUM_PAD_CONTAINER_VIEW_ID, NUM_PAD_VIEW_ID])}
	style={[styles.w100, styles.justifyContentEnd, styles.pageWrapper, styles.pt0]}
	id={NUM_PAD_CONTAINER_VIEW_ID}
	>

<View
                onMouseDown={(event) => onMouseDown(event, [NUM_PAD_CONTAINER_VIEW_ID, NUM_PAD_VIEW_ID])}
                style={[styles.w100, styles.justifyContentEnd, styles.pageWrapper, styles.pt0, Platform.OS !== 'web' ? [styles.dBlock, styles.w100, {height: '40%'}] : {}]}
                id={NUM_PAD_CONTAINER_VIEW_ID}
            >

And finally in

App/src/pages/iou/MoneyRequestAmountForm.tsx

Line 314 in 66b4072

<View style={styles.w100}>

:

<View style={[styles.w100, Platform.OS !== 'web' ? {height: '40%'} : {}]}>

This way we going to force to react native to recalculate the height of the component even when offline indicator are not displayed (when they doesn't exists in the rendered components).

Tests:

Before changes:

Map.view.overlap.next.button.-.test.before.changes.mp4

After changes

next.button.moved.test.mp4