refactor(Stack): Use more GetParticle

GetParticle is a thin wrapper. Let's use it more.

Author: ChristianTackeGSI

examples/common/mcstack/FairStack.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2025 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -167,7 +167,7 @@ TParticle* FairStack::PopPrimaryForTracking(Int_t iPrim)
 
     // Return the iPrim-th TParticle from the fParticle array. This should be
     // a primary.
-    TParticle* part = static_cast<TParticle*>(fParticles->At(iPrim));
+    TParticle* part = GetParticle(iPrim);
     if (!(part->GetMother(0) < 0)) {
         LOG(fatal) << "Not a primary track!" << iPrim;
     }
@@ -195,7 +195,6 @@ void FairStack::AddParticle(TParticle* oldPart)
 
 void FairStack::FillTrackArray()
 {
-
     LOG(debug) << "Filling MCTrack array...";
 
     // --> Reset index map and number of output tracks

templates/project_root_containers/MyProjData/MyProjStack.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2025 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -207,7 +207,7 @@ TParticle* MyProjStack::PopPrimaryForTracking(Int_t iPrim)
 
     // Return the iPrim-th TParticle from the fParticle array. This should be
     // a primary.
-    TParticle* part = (TParticle*)fParticles->At(iPrim);
+    TParticle* part = GetParticle(iPrim);
     if (!(part->GetMother(0) < 0)) {
         LOG(fatal) << "MyProjStack:: Not a primary track! " << iPrim;
     }
@@ -241,7 +241,6 @@ void MyProjStack::AddParticle(TParticle* oldPart)
 // -----   Public method FillTrackArray   ----------------------------------
 void MyProjStack::FillTrackArray()
 {
-
     LOG(debug) << "MyProjStack: Filling MCTrack array...";
 
     // --> Reset index map and number of output tracks
@@ -425,14 +424,13 @@ TParticle* MyProjStack::GetParticle(Int_t trackID) const
     if (trackID < 0 || trackID >= fNParticles) {
         LOG(fatal) << "MyProjStack: Particle index " << trackID << " out of range.";
     }
-    return (TParticle*)fParticles->At(trackID);
+    return static_cast<TParticle*>(fParticles->At(trackID));
 }
 // -------------------------------------------------------------------------
 
 // -----   Private method SelectTracks   -----------------------------------
 void MyProjStack::SelectTracks()
 {
-
     // --> Clear storage map
     fStoreMap.clear();
 

templates/project_stl_containers/MyProjData/MyProjStack.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2025 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -207,7 +207,7 @@ TParticle* MyProjStack::PopPrimaryForTracking(Int_t iPrim)
 
     // Return the iPrim-th TParticle from the fParticle array. This should be
     // a primary.
-    TParticle* part = (TParticle*)fParticles->At(iPrim);
+    TParticle* part = GetParticle(iPrim);
     if (!(part->GetMother(0) < 0)) {
         LOG(fatal) << "MyProjStack:: Not a primary track! " << iPrim;
     }
@@ -241,7 +241,6 @@ void MyProjStack::AddParticle(TParticle* oldPart)
 // -----   Public method FillTrackArray   ----------------------------------
 void MyProjStack::FillTrackArray()
 {
-
     LOG(debug) << "MyProjStack: Filling MCTrack array...";
 
     // --> Reset index map and number of output tracks
@@ -430,14 +429,13 @@ TParticle* MyProjStack::GetParticle(Int_t trackID) const
     if (trackID < 0 || trackID >= fNParticles) {
         LOG(fatal) << "MyProjStack: Particle index " << trackID << " out of range.";
     }
-    return (TParticle*)fParticles->At(trackID);
+    return static_cast<TParticle*>(fParticles->At(trackID));
 }
 // -------------------------------------------------------------------------
 
 // -----   Private method SelectTracks   -----------------------------------
 void MyProjStack::SelectTracks()
 {
-
     // --> Clear storage map
     fStoreMap.clear();