Dolphin emulation functions can't be imported

[tomasamado]

Using the stubs as reference I attempted importing emulation functions but they don't seem to exist. All of the other imports from Dolphin worked:

46:54:080 Scripting\Python\Modules\doliomodule.cpp:36
E[Scripting]: Script stderr: from dolphin import memory, controller, event, savestate, gui, emulation 46:54:080 Scripting\Python\Modules\doliomodule.cpp:36
E[Scripting]: Script stderr: ImportError: cannot import name 'emulation' from 'dolphin' (unknown location)

Please let me know if I'm misunderstanding the current funcitons available. Thanks in advance

[tomasamado]

Btw, the reason why I wanted to import emulation is so that I can directly stop the game while waiting for some other process to happen, so that frame advancing is dependant on this process happening outside of Dolphin. I assume this can also be possible by just using hotkeys but I wanted it to be independent of window focus and more clea. If there is another way of doing this with the current build also let me know :)

[Felk]

Hey, which build of dolphin did you use? It's possible that you downloaded the 2 years old pre-built preview while the emulation module was only added 8 months ago.

Given how half-heartedly at best I work on this project, I forgot to publish a new preview for that since then. And since the Windows 11 hardware requirement fiasco I switched to Linux.

If that's the problem, are you comfortable building from source? Otherwise I'll see about booting into windows 10 and making a new preview with the latest stuff

[tomasamado]

I do think I used that 2 year old release. My current Dolphin version reads "Dolphin 2412-155-dirty". I had some attempts at building from source but encountered a lot of issues so I reverted to just using the release version. I might try building from source sometime later this week. Thanks for the response.

[rprescottjr]

Hey, which build of dolphin did you use? It's possible that you downloaded the 2 years old pre-built preview while the emulation module was only added 8 months ago.

Given how half-heartedly at best I work on this project, I forgot to publish a new preview for that since then. And since the Windows 11 hardware requirement fiasco I switched to Linux.

If that's the problem, are you comfortable building from source? Otherwise I'll see about booting into windows 10 and making a new preview with the latest stuff

If feasible, would love to have an updated pre-built. I spent a bit of time attempting to build on Windows 11 and just ran into the same rabbit hole issues.

[Felk]

I booted my windows 10 back up and created a preview4: https://github.com/Felk/dolphin/releases/tag/scripting-preview4

Let me know if that works for you 🙏

[rprescottjr]

Hey Felk,

Took an initial stab at this and got some errors on startup. Looking at scripting-preview3 vs scripting-preview4 with Events.h, there seems to be some significant differences in the way events are emitted.

I saw from the notes the release was identified non-breaking. I haven't looked into a workaround yet for my use-case, but wanted to at least comment for visibility while I did some looking into things. If you have any suggestions that may be obvious to you, I'd gladly accept them.

[Felk]

Ahhh, thanks. Well I don't do much testing, so apparently I missed fixing that event. Quick fix for me would be to just remove that assertion and it should work just like in preview3. However, events emitted from other threads tend to be "crashy", hence I added the assertion.

Can you try to just "ignore for this session"? Does that run fine? Sorry for the trouble

[rprescottjr]

It looks like it was related to the View -> Code menu being opened. Closing this in preview-scripting3 to save the config value and opening preview-scripting4 with it closed resolves that issue and allows Dolphin to start.

My use-case also involved loading a savestate at the start of my Python script and that save state has been invalidated so I'll need to regenerate that, but that's no problem.

[unexploredtest]

BTW it might be beneficial to add github workflows to automatically build Dolphin for each commit/release. If interested I can make a PR that does so.

[Felk]

I'm very interested, that would be absolutely fantastic! Especially since I'm ditching Windows and currently rely on other people to tell me when the build breaks for other platforms.

Upstream also has build automation, but their setup is more elaborate and home-grown, so I always just assumed it's too complicated and never actually tried. If you can get it to work with a GitHub Action, that would be awesome

[unexploredtest]

Alright, I'll get to work on it after midterms. I've already written some workflows:
Linux (although this builds an appimage)
Mac OS
So I only need to modify the logic a little bit to get it to work.