-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething isn't workingSomething isn't workingquestionFurther information is requestedFurther information is requested
Description
In the situation when the startMonth != 1 (e.g. 2:12) in site_data we correctly assign the month when starting the loop. However not sure if the ii shall work correctly.
In such case the climate data shall start from the startMonth or from 1 (January).
Furthermore, if we are running multiple sites with different number of months (e.g. one for 5 years and another for 10 years) and they use different climateId then the climate array shall have 1012 rows. But for the first site we need only 512 rows. Shall the remaining part be filled with e.g. -999 and be excluded from calculations in the fortran code?
https://github.com/checcomi/threePGN-package/blob/cde0d55ab62494e8ada32314fc7e6572cd11a7db/r3pg/src/threePGN.f90#L404-L407
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingquestionFurther information is requestedFurther information is requested