From 140c92534eb17b3a074226d1b6e32bfc226b12b4 Mon Sep 17 00:00:00 2001 From: Mansoor Siddeeq Date: Fri, 31 Jan 2025 13:26:50 -0500 Subject: [PATCH 1/4] add default borerwidth value --- packages/victory-errorbar/src/helper-methods.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/victory-errorbar/src/helper-methods.tsx b/packages/victory-errorbar/src/helper-methods.tsx index 7ae18aaee..a8c03c095 100644 --- a/packages/victory-errorbar/src/helper-methods.tsx +++ b/packages/victory-errorbar/src/helper-methods.tsx @@ -223,7 +223,7 @@ export const getBaseProps = (initialProps, fallbackProps) => { const errorX = getErrors(props, formattedDatum, "x"); const errorY = getErrors(props, formattedDatum, "y"); const dataProps = { - borderWidth, + borderWidth: borderWidth ? borderWidth : 8, data, datum: formattedDatum, errorX: horizontal ? errorY : errorX, From 46a2fb666b0a5cc68776808ea46de9315b107980 Mon Sep 17 00:00:00 2001 From: Mansoor Siddeeq Date: Fri, 31 Jan 2025 14:09:57 -0500 Subject: [PATCH 2/4] move value to const --- packages/victory-errorbar/src/helper-methods.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/victory-errorbar/src/helper-methods.tsx b/packages/victory-errorbar/src/helper-methods.tsx index a8c03c095..a7d309e6f 100644 --- a/packages/victory-errorbar/src/helper-methods.tsx +++ b/packages/victory-errorbar/src/helper-methods.tsx @@ -215,6 +215,7 @@ export const getBaseProps = (initialProps, fallbackProps) => { width, }, }; + const DEFAULT_BORDER_WIDTH = 8; return data.reduce((childProps, datum, index) => { const eventKey = !Helpers.isNil(datum.eventKey) ? datum.eventKey : index; @@ -223,7 +224,7 @@ export const getBaseProps = (initialProps, fallbackProps) => { const errorX = getErrors(props, formattedDatum, "x"); const errorY = getErrors(props, formattedDatum, "y"); const dataProps = { - borderWidth: borderWidth ? borderWidth : 8, + borderWidth: borderWidth ? borderWidth : DEFAULT_BORDER_WIDTH, data, datum: formattedDatum, errorX: horizontal ? errorY : errorX, From d6cb5ba36d53521253de0eb8883f60d60a2ead24 Mon Sep 17 00:00:00 2001 From: Mansoor Siddeeq Date: Fri, 31 Jan 2025 14:10:37 -0500 Subject: [PATCH 3/4] format fix --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a9c7b0ca7..da8516f9f 100644 --- a/package.json +++ b/package.json @@ -455,4 +455,4 @@ "node": ">=18.0.0" } } -} \ No newline at end of file +} From 5a56034ff38dc03cab0424899dd786adae4cc557 Mon Sep 17 00:00:00 2001 From: Mansoor Siddeeq Date: Fri, 31 Jan 2025 14:14:23 -0500 Subject: [PATCH 4/4] add changeset --- .changeset/afraid-donuts-tease.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/afraid-donuts-tease.md diff --git a/.changeset/afraid-donuts-tease.md b/.changeset/afraid-donuts-tease.md new file mode 100644 index 000000000..52fbbb358 --- /dev/null +++ b/.changeset/afraid-donuts-tease.md @@ -0,0 +1,5 @@ +--- +"victory-errorbar": patch +--- + +add default borderwidth value