-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
There are imports of glycomimetics code inside glycoprotein (previously GpBuilder). These might be unused. I need to fix other things right now, so I'm leaving a note about it here. I did change one (see below).
- gemsModules/conjugate/glycoprotein/services/ProjectManagement/server.py:
- I removed this dependency because the referenced functions existed in the corresponding location in glycoprotein. It is possible this could cause trouble. I left notes:
# from gemsModules.complex.glycomimetics.services.ProjectManagement.api ...# I think the dependency should be on glycoprotein, not glycomimetics
- I removed this dependency because the referenced functions existed in the corresponding location in glycoprotein. It is possible this could cause trouble. I left notes:
- gemsModules/conjugate/glycoprotein/services/ProjectManagement/api.py:
from gemsModules.complex.glycomimetics.services.common_api import PDB_File_Resource- This import does not exist in conjugate/glycoprotein.
- The imported class should be abstracted and put into the structurefile/PDBFile entity.
- gemsModules/conjugate/glycoprotein/services/ProjectManagement/implied_translator.py:
from gemsModules.complex.glycomimetics.services.ProjectManagement.api import (- I also edited this one the same way I edited server.py.
Reactions are currently unavailable