Skip to content

Commit 5c04dd1

Browse files
committed
Building Guide - Clarity
Building Guide notification now omit relative altitudes (Y) in its notification if its area of operation is in 2D (1 Block tall). This should better hint to players that those 2 sets of 3 numbers spammed in chat are relative coordinates
1 parent 8208481 commit 5c04dd1

File tree

17 files changed

+34
-8
lines changed

17 files changed

+34
-8
lines changed

src/main/java/openblocks/common/tileentity/TileEntityGuide.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,15 +427,25 @@ public GuideShape decrementMode() {
427427
}
428428

429429
private void notifyPlayer(EntityPlayer player) {
430-
player.addChatMessage(
431-
new ChatComponentTranslation(
430+
boolean is2D = +posY.get() == 0 && -negY.get() == 0;
431+
432+
ChatComponentTranslation notification = is2D
433+
? new ChatComponentTranslation(
434+
"openblocks.misc.change_area_size",
435+
-negX.get(),
436+
-negZ.get(),
437+
+posX.get(),
438+
+posZ.get())
439+
: new ChatComponentTranslation(
432440
"openblocks.misc.change_box_size",
433441
-negX.get(),
434442
-negY.get(),
435443
-negZ.get(),
436444
+posX.get(),
437445
+posY.get(),
438-
+posZ.get()));
446+
+posZ.get());
447+
448+
player.addChatMessage(notification);
439449
displayBlockCount(player);
440450
}
441451

src/main/resources/assets/openblocks/lang/de_DE.lang

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ openblocks.misc.pointed_cannon=Kanone zielt nun auf %s, %s, %s
8989
openblocks.misc.change_mode=Wechsle zu %s-Modus
9090
openblocks.misc.change_size=Ändere Größe zu %sx%sx%s
9191
openblocks.misc.change_box_size=Ändere Größe zu (%d,%d,%d):(%d,%d,%d)
92+
openblocks.misc.change_area_size=Ändere Größe zu (%d,%d):(%d,%d)
9293
openblocks.misc.total_blocks=Insgesamt gezählte Blöcke: %d
9394
openblocks.misc.get_witched=Werde verhext!
9495
openblocks.misc.page=Seite %d von %d

src/main/resources/assets/openblocks/lang/en_US.lang

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ openblocks.misc.pointed_cannon=Pointed cannon at %s, %s, %s
8989
openblocks.misc.change_mode=Changing to %s mode
9090
openblocks.misc.change_size=Changing size to %sx%sx%s
9191
openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d)
92+
openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d)
9293
openblocks.misc.total_blocks=Total block count: %d
9394
openblocks.misc.get_witched=Get witched!
9495
openblocks.misc.page=Page %d of %d

src/main/resources/assets/openblocks/lang/es_AR.lang

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.pointed_cannon=Cañón apuntado a %s, %s, %s
8686
openblocks.misc.change_mode=Cambiando a modo %s
8787
openblocks.misc.change_size=Cambiando tamaño a %sx%sx%s
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
openblocks.misc.total_blocks=Número Total de Bloques: %d
9091
openblocks.misc.get_witched=¡Embrújate!
9192
openblocks.misc.page=Página %d de %d
@@ -273,7 +274,7 @@ tile.openblocks.drawingtable.description=La mesa de dibujo se usa para crear pla
273274

274275
tile.openblocks.grave.name=Tumba
275276
tile.openblocks.trophy.name=Trofeo
276-
tile.openblocks.trophy.entity.name=Trofeo de %s
277+
tile.openblocks.trophy.entity.name=Trofeo de %s
277278
tile.openblocks.canvasglass.name=Lienzo de cristal
278279
tile.openblocks.paintcan.name=Lata de pintura
279280

src/main/resources/assets/openblocks/lang/es_ES.lang

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.pointed_cannon=Cañón apuntado a %s, %s, %s
8686
openblocks.misc.change_mode=Cambiando a modo %s
8787
openblocks.misc.change_size=Cambiando tamaño a %sx%sx%s
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
openblocks.misc.total_blocks=Número Total de Bloques: %d
9091
openblocks.misc.get_witched=¡Embrújate!
9192
openblocks.misc.page=Página %d de %d
@@ -273,7 +274,7 @@ tile.openblocks.drawingtable.description=La mesa de dibujo se usa para crear pla
273274

274275
tile.openblocks.grave.name=Tumba
275276
tile.openblocks.trophy.name=Trofeo
276-
tile.openblocks.trophy.entity.name=Trofeo de %s
277+
tile.openblocks.trophy.entity.name=Trofeo de %s
277278
tile.openblocks.canvasglass.name=Lienzo de cristal
278279
tile.openblocks.paintcan.name=Lata de pintura
279280

src/main/resources/assets/openblocks/lang/es_MX.lang

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.pointed_cannon=Cañón apuntado a %s, %s, %s
8686
openblocks.misc.change_mode=Cambiando a modo %s
8787
openblocks.misc.change_size=Cambiando tamaño a %sx%sx%s
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
openblocks.misc.total_blocks=Número Total de Bloques: %d
9091
openblocks.misc.get_witched=¡Embrújate!
9192
openblocks.misc.page=Página %d de %d
@@ -273,7 +274,7 @@ tile.openblocks.drawingtable.description=La mesa de dibujo se usa para crear pla
273274

274275
tile.openblocks.grave.name=Tumba
275276
tile.openblocks.trophy.name=Trofeo
276-
tile.openblocks.trophy.entity.name=Trofeo de %s
277+
tile.openblocks.trophy.entity.name=Trofeo de %s
277278
tile.openblocks.canvasglass.name=Lienzo de cristal
278279
tile.openblocks.paintcan.name=Lata de pintura
279280

src/main/resources/assets/openblocks/lang/es_UY.lang

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.pointed_cannon=Cañón apuntado a %s, %s, %s
8686
openblocks.misc.change_mode=Cambiando a modo %s
8787
openblocks.misc.change_size=Cambiando tamaño a %sx%sx%s
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
openblocks.misc.total_blocks=Número Total de Bloques: %d
9091
openblocks.misc.get_witched=¡Embrújate!
9192
openblocks.misc.page=Página %d de %d
@@ -273,7 +274,7 @@ tile.openblocks.drawingtable.description=La mesa de dibujo se usa para crear pla
273274

274275
tile.openblocks.grave.name=Tumba
275276
tile.openblocks.trophy.name=Trofeo
276-
tile.openblocks.trophy.entity.name=Trofeo de %s
277+
tile.openblocks.trophy.entity.name=Trofeo de %s
277278
tile.openblocks.canvasglass.name=Lienzo de cristal
278279
tile.openblocks.paintcan.name=Lata de pintura
279280

src/main/resources/assets/openblocks/lang/es_VE.lang

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.pointed_cannon=Cañón apuntado a %s, %s, %s
8686
openblocks.misc.change_mode=Cambiando a modo %s
8787
openblocks.misc.change_size=Cambiando tamaño a %sx%sx%s
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
openblocks.misc.total_blocks=Número Total de Bloques: %d
9091
openblocks.misc.get_witched=¡Embrújate!
9192
openblocks.misc.page=Página %d de %d
@@ -273,7 +274,7 @@ tile.openblocks.drawingtable.description=La mesa de dibujo se usa para crear pla
273274

274275
tile.openblocks.grave.name=Tumba
275276
tile.openblocks.trophy.name=Trofeo
276-
tile.openblocks.trophy.entity.name=Trofeo de %s
277+
tile.openblocks.trophy.entity.name=Trofeo de %s
277278
tile.openblocks.canvasglass.name=Lienzo de cristal
278279
tile.openblocks.paintcan.name=Lata de pintura
279280

src/main/resources/assets/openblocks/lang/et_EE.lang

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.locked=Lukustatud
8686
#openblocks.misc.change_mode=Changing to %s mode ## NEEDS TRANSLATION ##
8787
#openblocks.misc.change_size=Changing size to %sx%sx%s ## NEEDS TRANSLATION ##
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
#openblocks.misc.total_blocks=Total block count: %d ## NEEDS TRANSLATION ##
9091
#openblocks.misc.get_witched=Get witched! ## NEEDS TRANSLATION ##
9192
#openblocks.misc.page=Page %d of %d ## NEEDS TRANSLATION ##

src/main/resources/assets/openblocks/lang/fr_FR.lang

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ openblocks.misc.pointed_cannon=Pointed cannon at %s, %s, %s
8686
openblocks.misc.change_mode=Changing to %s mode
8787
openblocks.misc.change_size=Changing size to %sx%sx%s
8888
#openblocks.misc.change_box_size=Changing size to (%d,%d,%d):(%d,%d,%d) ## NEEDS TRANSLATION ##
89+
#openblocks.misc.change_area_size=Changing size to (%d,%d):(%d,%d) ## NEEDS TRANSLATION ##
8990
openblocks.misc.total_blocks=Total block count: %d
9091
openblocks.misc.get_witched=Get witched!
9192
openblocks.misc.page=Page %d of %d

0 commit comments

Comments
 (0)