Build issue: expected identifier before numeric constant

[timhutton]

Reported by @danwills:

The build of the 'ready' GUI binary unfortunately died! saying this kinda thing:

from /home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/wxVTKRenderWindowInteractor.h:67,
                from /home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/frame.cpp:61:
/usr/include/vtk-9.0/vtkDataArray.h:602:8: error: expected identifier before numeric constant
 602 | struct AllValues
     |        ^~~~~~~~~
/usr/include/vtk-9.0/vtkDataArray.h:602:8: error: expected unqualified-id before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:417:37: error: expected identifier before numeric constant
 417 | bool DoComputeVectorRange(A*, R[2], AllValues);
     |                                     ^~~~~~~~~

[timhutton]

gcc version 11.2.0 (Gentoo 11.2.0 p1)
VTK version is 9.0.3

[danwills]

Thanks heaps for making an issue for this Tim!

I found this:
https://gitlab.kitware.com/vtk/vtk/-/issues/18048

Where someone gets around it by renaming AllValues to vtkAllValues.. but Ready doesn't (as far as I can tell) even have anything called 'AllValues' in it.. and the traceback indicates the problem is at this line in wxVTKWindowInteractor: #include <wx/glcanvas.h>. Maybe if the include were moved after the VTK include.. that didn't seem to help when I tried it.. I guess there might be other vtk imports above.

I'll paste the full log in the next message.

Edit: typo.

[danwills]

Here's the whole end of the build log from just before the error:

Consolidate compiler generated dependencies of target ready
[ 92%] Building CXX object CMakeFiles/ready.dir/src/gui/frame.cpp.o
In file included from /usr/include/GL/glx.h:31,
                 from /usr/include/wx-3.0-gtk3/wx/unix/glx11.h:13,
                 from /usr/include/wx-3.0-gtk3/wx/gtk/glcanvas.h:14,
                 from /usr/include/wx-3.0-gtk3/wx/glcanvas.h:195,
                 from /home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/wxVTKRenderWindowInteractor.h:72,
                 from /home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/frame.cpp:61:
/usr/include/vtk-9.0/vtkDataArray.h:602:8: error: expected identifier before numeric constant
  602 | struct AllValues
      |        ^~~~~~~~~
/usr/include/vtk-9.0/vtkDataArray.h:602:8: error: expected unqualified-id before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:417:37: error: expected identifier before numeric constant
  417 | bool DoComputeVectorRange(A*, R[2], AllValues);
      |                                     ^~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:417:37: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:519:37: error: expected identifier before numeric constant
  519 | bool DoComputeVectorRange(A*, R[2], AllValues);
      |                                     ^~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:519:37: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected identifier before numeric constant
  551 | VTK_DECLARE_VALUERANGE_VALUETYPE(long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected identifier before numeric constant
  551 | VTK_DECLARE_VALUERANGE_VALUETYPE(long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected identifier before numeric constant
  551 | VTK_DECLARE_VALUERANGE_VALUETYPE(long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected identifier before numeric constant
  551 | VTK_DECLARE_VALUERANGE_VALUETYPE(long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:551:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected identifier before numeric constant
  552 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected identifier before numeric constant
  552 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected identifier before numeric constant
  552 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected identifier before numeric constant
  552 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:552:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected identifier before numeric constant
  553 | VTK_DECLARE_VALUERANGE_VALUETYPE(long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected identifier before numeric constant
  553 | VTK_DECLARE_VALUERANGE_VALUETYPE(long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected identifier before numeric constant
  553 | VTK_DECLARE_VALUERANGE_VALUETYPE(long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected identifier before numeric constant
  553 | VTK_DECLARE_VALUERANGE_VALUETYPE(long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:553:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected identifier before numeric constant
  554 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected identifier before numeric constant
  554 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected identifier before numeric constant
  554 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected identifier before numeric constant
  554 | VTK_DECLARE_VALUERANGE_VALUETYPE(unsigned long long)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:554:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:555:1: error: expected identifier before numeric constant
  555 | VTK_DECLARE_VALUERANGE_ARRAYTYPE(vtkDataArray, double)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:555:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.h:555:1: error: expected identifier before numeric constant
  555 | VTK_DECLARE_VALUERANGE_ARRAYTYPE(vtkDataArray, double)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.h:555:1: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/vtk-9.0/vtkGenericDataArray.txx: In member function ‘bool vtkGenericDataArray<DerivedT, ValueTypeT>::ComputeScalarValueRange(vtkGenericDataArray<DerivedT, ValueTypeT>::ValueType*)’:
/usr/include/vtk-9.0/vtkGenericDataArray.txx:1195:64: error: expected unqualified-id before numeric constant
 1195 |     static_cast<DerivedT*>(this), ranges, vtkDataArrayPrivate::AllValues{}, Supported{});
      |                                                                ^~~~~~~~~
/usr/include/vtk-9.0/vtkGenericDataArray.txx: In member function ‘bool vtkGenericDataArray<DerivedT, ValueTypeT>::ComputeVectorValueRange(vtkGenericDataArray<DerivedT, ValueTypeT>::ValueType*)’:
/usr/include/vtk-9.0/vtkGenericDataArray.txx:1205:63: error: expected unqualified-id before numeric constant
 1205 |     static_cast<DerivedT*>(this), range, vtkDataArrayPrivate::AllValues{}, Supported{});
      |                                                               ^~~~~~~~~
make[2]: *** [CMakeFiles/ready.dir/build.make:168: CMakeFiles/ready.dir/src/gui/frame.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:168: CMakeFiles/ready.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

[danwills]

I wish I could more easily patch my system VTK, I think I probably could since it's gentoo, but maybe I'll build a bleeding-edge VTK and see if it's fixed there, and/or apply a rename to that AllValues thing and see if that gets me a build. I'm rather missing being able to open my VTIs for sure! :D

[danwills]

I built vtk 9.2.2 and still had the "AllValues" trouble when building ready.. so I applied the idea (mentioned in link above) to rename 'AllValues' to 'vtkAllValues' and rebuilt VTK.. aand that takes a fair old while on my rig, so will update once I know if that sorted it.. but I'm wondering should this be suggested as a patch/pullRequest to VTK? I think there's already some awareness about this over there... see how it goes I guess?

[danwills]

Cool that got me past the previous problem (vtk-9.2.2 patch file coming soon!) but I'm now stuck on this:

[ 95%] Building CXX object CMakeFiles/ready.dir/src/gui/vtk_pipeline.cpp.o
In file included from /home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/vtk_pipeline.cpp:20:
/home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/wxVTKRenderWindowInteractor.h:46:4: error: #error "problem of wxGLCanvas, you need to build wxWidgets with opengl"
   46 |   #error "problem of wxGLCanvas, you need to build wxWidgets with opengl"
      |    ^~~~~
In file included from /home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/vtk_pipeline.cpp:20:
/home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/wxVTKRenderWindowInteractor.h:86:54: error: expected class-name before ‘,’ token
   86 | class wxVTKRenderWindowInteractor : public wxGLCanvas, public vtkRenderWindowInteractor
      |                                                      ^
/home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/wxVTKRenderWindowInteractor.h:178:5: error: ‘wxGLContext’ does not name a type
  178 |     wxGLContext* GLContext;
      |     ^~~~~~~~~~~
/home/dan/dev/ready/readyGit/17thSept2022/ready/src/gui/wxVTKRenderWindowInteractor.h:113:10: error: ‘bool wxVTKRenderWindowInteractor::Enable(bool)’ marked ‘override’, but does not override
  113 |     bool Enable(bool enable) override;
      |          ^~~~~~
make[2]: *** [CMakeFiles/ready.dir/build.make:238: CMakeFiles/ready.dir/src/gui/vtk_pipeline.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:168: CMakeFiles/ready.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

I checked my Gentoo's wxGTK install (it's called x11-libs/wxGTK) and it claims to have been built with opengl USE flags, I'm reinstalling it again now just in case there's some lib that wasn't up to date or something! Will report back once I have a result.

[danwills]

Arghh now it won't even ccmake-configure, saying stuff we probably shouldn't care about, and I will work out tomorrow if I get time! sounds like gentoo-gtk-level kinda?)\

Found OpenMP_CXX: -fopenmp
 CMake Error at CMakeLists.txt:455 (message):
   Didn't find -lwx_gtk2u_core-3.0 or -lwx_gtk3u_core-3.0 in
   wxWidgets_LIBRARIES - unable to detect GTK version to use:
   -L/usr/lib64;-pthread;;;-lwx_gtk3u_html-3.0-gtk3;-lwx_gtk3u_aui-3.0-gtk3;-lwx_gtk3u_gl-3.0-gtk3;-lwx_gtk3u_core-3.0-gtk3;-lwx_gtk3u_adv-3.0-gtk3;-lwx_baseu-3.0-gtk3

 Configuring incomplete, errors occurred!

[timhutton]

Thanks for investigating. Looks like a bug in wxVTKRenderWindowInteractor. A more updated repo is here: https://github.com/vadz/wxVTK

Historically wxVTK has always been problematic because it uses accesses non-public parts of the VTK API and thus gets broken when they change internal things.

[danwills]

Edit: Deleting this as I say it in the next message first paragraph! whoops, double post.

[danwills]

Thanks for the guidance @timhutton :) I did grab that wxVTK but for a long time it wouldn't configure as there were some things that it needed that I didn't have enabled in my VTK build so I've enabled them and am rebuilding.. VTK takes yonks! Hopefully I can build the wxVTK once that's all done.

I got VTK built, and rebuilt a fair few times until I did get past configure for that wxVTK (but I cheated since I turned some checks off) and ultimately ran into all sorts of other issues.

It seems to me now that my vague plan to try a very-new VTK (9.2.2) is potentially just a very bad idea because of the wxVTK dependency.. it sounds like things were working better at vtk8.2.0 (at least that version is mentioned in our BUILD.txt) so maybe I'll try that next!

[danwills]

Aww I got all through configure and the VTK-8.2.0 build died here:

/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: CMakeFiles/vtkexodusII.dir/src/ex_open_par.c.o:/home/dan/dev/vtk/8.2.0/VTK-8.2.0/ThirdParty/exodusII/vtkexodusII/src/ex_open_par.c:477: multiple definition of `exodus_unused_symbol_dummy_1'; CMakeFiles/vtkexodusII.dir/src/ex_create_par.c.o:/home/dan/dev/vtk/8.2.0/VTK-8.2.0/ThirdParty/exodusII/vtkexodusII/src/ex_create_par.c:617: first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [ThirdParty/exodusII/vtkexodusII/CMakeFiles/vtkexodusII.dir/build.make:4436: lib/libvtkexodusII-8.2.so.1] Error 1
make[1]: *** [CMakeFiles/Makefile2:5607: ThirdParty/exodusII/vtkexodusII/CMakeFiles/vtkexodusII.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

looking into it...

[danwills]

I think it might be a gcc-version thing, annoyingly:
https://gitlab.kitware.com/vtk/vtk/-/issues/17774

[danwills]

It sounds like this was fixed in VTK around these merges:
https://gitlab.kitware.com/vtk/vtk/-/issues/17774
I just need to work out what 8.2.X they landed in, then find or clone the source for that version, and hopefully that will work!

[danwills]

In the end I manually applied the patch file (from https://gitlab.kitware.com/vtk/vtk/-/merge_requests/6420) to fix vtkExodusII in the vtk 8.2.0 source (there were only 2 lines with very clear changes), and that got me going on gcc11!

I found I had to add this to the CmakeLists.txt for VTK:

set(VTK_USE_HYBRID ON CACHE BOOL "doc" FORCE)

Otherwise wxVTK was unhappy.. and in fact I didn't even get through the VTK build.. new error is:

/home/dan/dev/vtk/8.2.0/VTK-8.2.0/Rendering/Qt/vtkQtLabelRenderStrategy.cxx:229:18: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined

I can only assume this is a gcc-version thing too.. no idea yet though.. looking into it

[danwills]

In the end after I pasted this in a few places (in ".h" files in VTK):
#include <QPainterPath>
I got a VTK build completed but I still couldn't make wxVTK happy now it says this:

[  8%] Building CXX object CMakeFiles/wxImagePlaneWidget.dir/Sample/wxImagePlaneWidget.cxx.o
/home/dan/dev/wxVTK/wxVTK/Sample/wxImagePlaneWidget.cxx:41:10: fatal error: vtkTesting.h: No such file or directory
   41 | #include "vtkTesting.h"
      |          ^~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/wxImagePlaneWidget.dir/build.make:76: CMakeFiles/wxImagePlaneWidget.dir/Sample/wxImagePlaneWidget.cxx.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:89: CMakeFiles/wxImagePlaneWidget.dir/all] Error 2
make: *** [Makefile:136: all] Error 2