Skip to content

Misleading name and description for reconcile-interval-seconds flag #87

@bcheung

Description

@bcheung

This may be a breaking change, so fix this on the next major release. The reconcile-interval-seconds flag has a misleading name and description for time.Duration type, remove "seconds" from flag name and description and update netd.yaml as well.
Note: #86 fixes the default value for the reconcile-interval-seconds flag.

fs.DurationVar(&nc.ReconcileIntervalSeconds, "reconcile-interval-seconds", 10,
"Reconcile interval in seconds.")

netd/netd.yaml

Line 100 in fef8459

reconcile_interval_seconds: "60s"

netd/netd.yaml

Line 204 in fef8459

- --reconcile-interval-seconds=$(RECONCILE_INTERVAL_SECONDS)

netd/netd.yaml

Line 213 in fef8459

- name: RECONCILE_INTERVAL_SECONDS

netd/netd.yaml

Line 217 in fef8459

key: reconcile_interval_seconds

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions