-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Description
This may be a breaking change, so fix this on the next major release. The reconcile-interval-seconds flag has a misleading name and description for time.Duration type, remove "seconds" from flag name and description and update netd.yaml as well.
Note: #86 fixes the default value for the reconcile-interval-seconds flag.
Lines 40 to 41 in fef8459
| fs.DurationVar(&nc.ReconcileIntervalSeconds, "reconcile-interval-seconds", 10, | |
| "Reconcile interval in seconds.") |
Line 100 in fef8459
| reconcile_interval_seconds: "60s" |
Line 204 in fef8459
| - --reconcile-interval-seconds=$(RECONCILE_INTERVAL_SECONDS) |
Line 213 in fef8459
| - name: RECONCILE_INTERVAL_SECONDS |
Line 217 in fef8459
| key: reconcile_interval_seconds |
Metadata
Metadata
Assignees
Labels
No labels