Skip to content

metadata: panic with additional information in rare panic case #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
braydonk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

metadata: panic with additional information in rare panic case #2183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions integration_test/metadata/integration_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"slices"

"cloud.google.com/go/monitoring/apiv3/v2/monitoringpb"
"github.com/GoogleCloudPlatform/ops-agent/integration_test/util"
"github.com/go-playground/validator/v10"
yaml "github.com/goccy/go-yaml"
"go.uber.org/multierr"
Expand Down Expand Up @@ -294,6 +295,18 @@ func assertMetricLabels(metric *ExpectedMetric, series *monitoringpb.TimeSeries)
// Only expected labels must be present
expectedLabels := make(map[string]bool)
for _, expectedLabel := range metric.Labels {
// This is an attempt to catch a segfault we have not been
// able to reproduce yet. b/477046139
// - braydonk
if expectedLabel == nil {
panic(fmt.Sprintf(
`this failure case appears to occur at random in a way we can't reproduce. this panic exists to dump more information for the scenario where it occurs.
metric name: %v
expected labels: %v`,
metric.Type,
util.DumpPointerArray(metric.Labels, "%v"),
))
}
expectedLabels[expectedLabel.Name] = true
}
for actualLabel, actualValue := range series.Metric.Labels {
Expand Down
2 changes: 0 additions & 2 deletions integration_test/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build integration_test

package util

import (
Expand Down
Loading