Skip to content

Improve Ops Agent integration tests #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rafaelwestphal wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Improve Ops Agent integration tests #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1b5222
Removing unnecessary service name
rafaelwestphal Jan 28, 2026
46a85a3
Refactoring prometheus tests
rafaelwestphal Jan 30, 2026
0ec321d
Refactor integartion test for prometheus metrics
rafaelwestphal Feb 3, 2026
79ccbcf
Merge branch 'master' into westphalrafael-improve-test
rafaelwestphal Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion integration_test/metadata/integration_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ package metadata
import (
"bytes"
"fmt"
"net"
"os"
"reflect"
"regexp"
"slices"
Expand Down Expand Up @@ -303,12 +305,30 @@ func assertMetricLabels(metric *ExpectedMetric, series *monitoringpb.TimeSeries)
}
// All expected labels must be present and match the given pattern
for _, expectedLabel := range metric.Labels {

actualValue, ok := series.Metric.Labels[expectedLabel.Name]
if !ok {
err = multierr.Append(err, fmt.Errorf("expected label not found: %s", expectedLabel))
continue
}
match, matchErr := regexp.MatchString(fmt.Sprintf("^(?:%s)$", expectedLabel.ValueRegex), actualValue)
var matchErr error
// public_ip and private_ip labels will be different according to where the test is running (kokoro or cloudtop).
// https://github.com/GoogleCloudPlatform/opentelemetry-operations-collector/blob/32b5f554a82ff840e690eaf325d83cbff83f3f62/integration_test/gce-testing-internal/gce/gce_testing.go#L2158
useInternalIP := os.Getenv("USE_INTERNAL_IP") != ""
if (expectedLabel.Name == "public_ip" && useInternalIP) || (expectedLabel.Name == "private_ip" && !useInternalIP) {
// just check if it is a valid IP address
validIP := net.ParseIP(actualValue)
if validIP == nil {
err = multierr.Append(err, fmt.Errorf("error parsing pattern. label=%s, pattern=%s, err=%v",
expectedLabel.Name,
expectedLabel.ValueRegex,
matchErr,
))
}
continue
}
var match bool
match, matchErr = regexp.MatchString(fmt.Sprintf("^(?:%s)$", expectedLabel.ValueRegex), actualValue)
if matchErr != nil {
err = multierr.Append(err, fmt.Errorf("error parsing pattern. label=%s, pattern=%s, err=%v",
expectedLabel.Name,
Expand Down
Loading
Loading