feat: configure typehints, better documentation, refactor tests (#151)

Author: bshaffer

…radeFixer/examples/legacy_class_vars.php examples/class_vars.legacy.phpsrc/Fixers/ClientUpgradeFixer/examples/legacy_class_vars.php renamed to examples/class_vars.legacy.php src/Fixers/ClientUpgradeFixer/examples/legacy_class_vars.php renamed to examples/class_vars.legacy.php

@@ -13,7 +13,7 @@
 // new client surface won't exist (not a generator client)
 use Google\Cloud\Storage\StorageClient;
 
-class ClientWrapper extends TestCase
+class ClientWrapper
 {
     public $dlp;
     public $secretmanager;
@@ -33,6 +33,11 @@ public function callSecretManager()
     {
         $secrets = $this->secretmanager->listSecrets('this/is/a/parent');
     }
+
+    public function callDlpFromFunction(DlpServiceClient $client)
+    {
+        $infoTypes = $client->listInfoTypes();
+    }
 }
 
 // Instantiate a wrapping object.

…UpgradeFixer/examples/new_class_vars.php examples/class_vars.new.phpsrc/Fixers/ClientUpgradeFixer/examples/new_class_vars.php renamed to examples/class_vars.new.php src/Fixers/ClientUpgradeFixer/examples/new_class_vars.php renamed to examples/class_vars.new.php

@@ -15,7 +15,7 @@
 use Google\Cloud\SecretManager\V1\ListSecretsRequest;
 use Google\Cloud\Storage\StorageClient;
 
-class ClientWrapper extends TestCase
+class ClientWrapper
 {
     public $dlp;
     public $secretmanager;
@@ -38,14 +38,20 @@ public function callSecretManager()
             ->setParent('this/is/a/parent');
         $secrets = $this->secretmanager->listSecrets($listSecretsRequest);
     }
+
+    public function callDlpFromFunction(DlpServiceClient $client)
+    {
+        $listInfoTypesRequest2 = new ListInfoTypesRequest();
+        $infoTypes = $client->listInfoTypes($listInfoTypesRequest2);
+    }
 }
 
 // Instantiate a wrapping object.
 $wrapper = new ClientWrapper();
 
 // these should update
-$listInfoTypesRequest2 = new ListInfoTypesRequest();
-$infoTypes = $wrapper->dlp->listInfoTypes($listInfoTypesRequest2);
+$listInfoTypesRequest3 = new ListInfoTypesRequest();
+$infoTypes = $wrapper->dlp->listInfoTypes($listInfoTypesRequest3);
 $listSecretsRequest2 = (new ListSecretsRequest())
     ->setParent('this/is/a/parent');
 $secrets = $wrapper->secretmanager->listSecrets($listSecretsRequest2);

…adeFixer/examples/legacy_inline_html.php examples/inline_html.legacy.phpsrc/Fixers/ClientUpgradeFixer/examples/legacy_inline_html.php renamed to examples/inline_html.legacy.php src/Fixers/ClientUpgradeFixer/examples/legacy_inline_html.php renamed to examples/inline_html.legacy.php

@@ -4,6 +4,7 @@
 
 use Google\Cloud\SecretManager\V1\SecretManagerServiceClient;
 use Google\Cloud\Dlp\V2\DlpServiceClient;
+use Google\Protobuf\Internal\Message;
 
 // Instantiate clients for calling the Google Cloud APIs.
 $secretManagerClient = new SecretManagerServiceClient();

…pgradeFixer/examples/new_inline_html.php examples/inline_html.new.phpsrc/Fixers/ClientUpgradeFixer/examples/new_inline_html.php renamed to examples/inline_html.new.php src/Fixers/ClientUpgradeFixer/examples/new_inline_html.php renamed to examples/inline_html.new.php

@@ -6,6 +6,7 @@
 use Google\Cloud\Dlp\V2\ListDlpJobsRequest;
 use Google\Cloud\SecretManager\V1\Client\SecretManagerServiceClient;
 use Google\Cloud\SecretManager\V1\ListSecretsRequest;
+use Google\Protobuf\Internal\Message;
 
 // Instantiate clients for calling the Google Cloud APIs.
 $secretManagerClient = new SecretManagerServiceClient();