Corrupted files

[richardacre]

Copied DCIM folder to my laptop using this, but about 80% of the files are corrupted, videos won't play etc. Took a few minutes. About 500 files / 2GB . Used latest version of Dukan , Pixel 4a , Windows 11

[read-0nly]

Same issue, windows 10, Galaxy note 20. Copying the old fashion way, while much slower, doesn't corrupt files. Opening the files on the created drive works fine too, it's just in the copy. Using usb3 cable but it's the one that came with the phone, which from what I read online is USB3 ports but USB2-limited

[read-0nly]

My guess is it has to do with data being caught in the buffer when copying and it not getting finalized properly before the stream is closed? But this is a blind guess.

[GustavLindberg99]

I've seen this happen once, but it only seems to happen very rarely and I'm not able reproduce it. As a workaround, try opening/copying the files again (or if that doesn't work, unplug and re-plug the phone).

[AlexLev59]

Zip files copied from a disk created in AndroidDrive are almost all defective.

Example:

IMG_20241116_192504_461.jpg is the original file.

1.zip is IMG_20241116_192504_461.jpg in the archive.

2.zip is the defective 1.zip, - copied to the computer from the disk created in AndroidDrive.
1.zip
2.zip
foto1
foto2

[EDW9700]

Same here (Win10 and Samsung S23):

• installed AndroidDrive
• copied a few JPEG's
• all corrupt
• opening/copying the files again and unplug and re-plug the phone changed nothing
• ExifToolGui reports "File Format Error"
• copying in mass storage mode (= without AndroidDrive) works perfectly fine.
• a compare of a correct and the corrupt file gave: 4343 Match - 4790 Diff Lines:

• 4788 Added
• 2 Removed
• 2 Changed
  20250111_160903 - correct.zip

[UpperClassGit]

Hello Gustav, I love the program and have just started using it a couple of days ago. Unfortunately I see exactly the same problem with transfering jpgs. About 50% of the jpgs are corrupted and I can reproduce this on my PC Win 10 - Samsung Galaxy S23. I restarted both devices and fiddled with a lot of settings. Every single time there are corrupted files. I am happy to let you connect to my PC via teamviewer if you cant reproduce this issue on your machine. I am using AndroidDrive to make backups of my Mobile Phone Fotos to my PC. With this bug its unfortunately not possible. Best regards. J

[UpperClassGit]

Hello again, I will attach 4 jpg files. 2 originals and 2 corrupted versions after copying the files using AndroidDrive. This is not related to the amount of data being transfered. It happens if I just copy 1 file the same as it does if I transfer (copy) 500 files. It seems like there is a small hickup with a buffer or cache. All files will be copied but there is some sort of corruption going on. If you can point me to the routine, that is used for this process, I might be able to have a look myself. Best regards, Jörg

AndroidDrive Corruption Example Jpg.zip

[GustavLindberg99]

Hello again, I will attach 4 jpg files. 2 originals and 2 corrupted versions after copying the files using AndroidDrive.

That's helpful, thank you. Based on that I'm guessing that the issue might be that ADB pushes the file before Dokan is finished writing to it. I built a version that might fix the problem, but since I can't reproduce this problem reliably myself I'm not sure. I'm attaching it here so that you can try it, let me know how it works.

AndroidDrive.zip (This zip file only contains the exe file, the other files are the same as in the latest stable version.)

If you can point me to the routine, that is used for this process, I might be able to have a look myself.

It's the TemporaryFile class that handles this. TemporaryFile::write writes the contents to a local temporary file, and TemporaryFile::push uses ADB to push that local temporary file to the Android device. These methods are called in dokanoperations.cpp. The TemporaryFile objects themselves are created in AndroidDrive::addTemporaryFile line 221 and deleted in AndroidDrive::deleteTemporaryFile line 246 (these methods are also called dokanoperations.cpp).

In the version I attached above, I added a call to push() at the end of the TemporaryFile destructor (temporaryfile.cpp line 49).

[UpperClassGit]

Hello Gustav, thanks for your quick reply. The new exe did not solve the problem. Just some additional information:
When I open the mobile phone drive and go to the directory where my jpgs are and look at them in preview/thumbnail mode in the windows explorer, all thumbnails are looking fine. Which might be another hint that this is exclusively a problem with the copy process. I will have a look at the code, if I find time. But then I am not really a cpp expert. If you come up with a different solution I am always happy to test it. Best regards, J

[UpperClassGit]

Hi Gustav, I didnt have time to look at the code yet. Just downloaded the latest version, the problem persists. I.e. 80% of the copied jpg are corrupted. Have a merry X-mas ... J