From a3ef0bb9efc166d626f3c66e025e0cf26ec8fd4e Mon Sep 17 00:00:00 2001 From: Sahil Gaba Date: Tue, 6 Feb 2024 00:52:01 -0500 Subject: [PATCH 1/5] tseting --- react-app/src/App.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/react-app/src/App.tsx b/react-app/src/App.tsx index e47af89..c8e1155 100644 --- a/react-app/src/App.tsx +++ b/react-app/src/App.tsx @@ -7,6 +7,7 @@ function App(): JSX.Element { Hello}> Not Hello}> + Page Not Found}> ); From 24ecc3c31f101a9a1f451fb8f4717886a3b5af5e Mon Sep 17 00:00:00 2001 From: Sahil Gaba Date: Tue, 6 Feb 2024 00:53:20 -0500 Subject: [PATCH 2/5] tseting --- .../workflows/firebase-hosting-pull-request.yml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index 4f588a7..abb3fb4 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -8,11 +8,20 @@ jobs: if: "${{ github.event.pull_request.head.repo.full_name == github.repository }}" runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - run: npm ci && npm run build + - uses: actions/checkout@v2 + with: + persist-credentials: false + - name: Install npm dependencies + working-directory: ./react-app + run: npm install + - name: npm init + run: npm init -y + - name: deploy it + working-directory: ./react-app + run: CI=false && npm run build - uses: FirebaseExtended/action-hosting-deploy@v0 with: entryPoint: ./react-app repoToken: "${{ secrets.GITHUB_TOKEN }}" - firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3_E2B32 }}" + firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_YKNOT_42027 }}" projectId: prject3-e2b32 From 559843dd06d32de30144fd1491e92e662af5bfa8 Mon Sep 17 00:00:00 2001 From: Sahil Gaba Date: Tue, 6 Feb 2024 00:56:08 -0500 Subject: [PATCH 3/5] tseting --- .github/workflows/firebase-hosting-pull-request.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index abb3fb4..d202111 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -12,16 +12,16 @@ jobs: with: persist-credentials: false - name: Install npm dependencies - working-directory: ./react-app + working-directory: ./react-app # Make sure your react-app is called react-app run: npm install - name: npm init run: npm init -y - name: deploy it - working-directory: ./react-app + working-directory: ./react-app # Make sure your react-app is called react-app run: CI=false && npm run build - uses: FirebaseExtended/action-hosting-deploy@v0 with: - entryPoint: ./react-app + entryPoint: ./react-app # Make sure your react-app is called react-app repoToken: "${{ secrets.GITHUB_TOKEN }}" - firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_YKNOT_42027 }}" - projectId: prject3-e2b32 + firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3-e2b32 }}" + projectId: prject3-e2b32 # Change to your project name From 59a897202f8a03198f32e1b511ca9d063dcedab6 Mon Sep 17 00:00:00 2001 From: Sahil Gaba Date: Tue, 6 Feb 2024 00:58:27 -0500 Subject: [PATCH 4/5] tseting --- .github/workflows/firebase-hosting-pull-request.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index d202111..8b2a198 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -8,7 +8,7 @@ jobs: if: "${{ github.event.pull_request.head.repo.full_name == github.repository }}" runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Install npm dependencies @@ -23,5 +23,5 @@ jobs: with: entryPoint: ./react-app # Make sure your react-app is called react-app repoToken: "${{ secrets.GITHUB_TOKEN }}" - firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3-e2b32 }}" - projectId: prject3-e2b32 # Change to your project name + firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3-e2b32 }}" # Make sure your change this to your project id + projectId: prject3-e2b32 # Change to your project id From dd2c280daa15f21a45d3b54d86c4ba312e9454fc Mon Sep 17 00:00:00 2001 From: Sahil Gaba Date: Tue, 6 Feb 2024 00:59:05 -0500 Subject: [PATCH 5/5] tseting --- .github/workflows/firebase-hosting-pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index 8b2a198..6b4d2fa 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -23,5 +23,5 @@ jobs: with: entryPoint: ./react-app # Make sure your react-app is called react-app repoToken: "${{ secrets.GITHUB_TOKEN }}" - firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3-e2b32 }}" # Make sure your change this to your project id + firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3-E2B32 }}" # Make sure your change this to your project id projectId: prject3-e2b32 # Change to your project id