Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm ci && npm run build
with:
persist-credentials: false
- name: Install npm dependencies
working-directory: ./react-app # Make sure your react-app is called react-app
run: npm install
- name: npm init
run: npm init -y
- name: deploy it
working-directory: ./react-app # Make sure your react-app is called react-app
run: CI=false && npm run build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
entryPoint: ./react-app
entryPoint: ./react-app # Make sure your react-app is called react-app
repoToken: "${{ secrets.GITHUB_TOKEN }}"
firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3_E2B32 }}"
projectId: prject3-e2b32
firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_PRJECT3-E2B32 }}" # Make sure your change this to your project id
projectId: prject3-e2b32 # Change to your project id
1 change: 1 addition & 0 deletions react-app/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function App(): JSX.Element {
<Routes>
<Route path="/first" element={<h1>Hello</h1>}></Route>
<Route path="/second" element={<h1>Not Hello</h1>}></Route>
<Route path="*" element={<h1>Page Not Found</h1>}></Route>
</Routes>
</BrowserRouter>
);
Expand Down