Support for mail params with send method

[AkshayRajMaurya]

Hi,

the mail method in the SmtpRequests class with signature mail(CharSequence sender, CharSequence... mailParameters) has the capability to accept mailParameters, but the way send and sendInternal methods are written , it restricts the capability to pass mailParameters on users will and bounds it to available Extensions of SMTPUTF8 and 8BITMIME only. We would like to extend the capability to pass additional mail params. Should we contribute a change or can you suggest an alternative way we can do that ? We can use DefaultSmtpRequest(SmtpCommand.MAIL, params) but we want to keep the extended functionalities of sendInternal() method in place when placing the send request along with the additional mailParameters.

Thanks.

[benimohit]

+1 for this enhancement. If someone can provide the write access to this repo or add this support, it will be highly appreciated.

[benimohit]

@jhaber @mcobrien
Tagging for attention :)

[mcobrien]

Hi there! The client, and the sendInternal method, are designed to use whatever SMTP features are most appropriate given the capabilities of the server, which is why they don't currently support arbitrary additional parameters.

What extra parameters do you want to include? I'm wondering how to best offer this and keep the interface simple. Thanks!

[benimohit]

@mcobrien We would like to use local extension, verbs starting with X to pass some information to our downstream MTAs.

[mcobrien]

thanks @benimohit. I can't find an RFC for that feature, do you have a link for more details? How is it used?

[benimohit]

It is a private extension. It is short for Conversion Tag, which is a concept of our downstream MTA.
@mcobrien

[mcobrien]

I wonder if a way to implement this cleanly would be to add overloads of send that accept MAIL and RCPT commands instead of strings representing the sender and recipients. If you want to submit a PR we can take a look. Thanks! 🙂

[AkshayRajMaurya]

@mcobrien I was about to raise a PR but I guess I don't have access :
" remote: Permission to HubSpot/NioSmtpClient.git denied to AkshayRajMaurya."

[mcobrien]

Hey @AkshayRajMaurya did you fork the repo first? This guide might be useful. Thanks!

[AkshayRajMaurya]

Hey @mcobrien I have created the pull request. Thanks a lot :)

[benimohit]

@mcobrien please check the PR. Thanks!