Skip to content

SPI & PBPZ: Investigate hook subscription management #14

@HunterZ

Description

@HunterZ

May be worth selectively unsubscribing from hooks in one or both plugins.

In particular, PBPZ shouldn't be listening to damage hooks if using TruePVE's new API.

Also, SPI could potentially stop listening to plugin-specific PVP delay hooks for plugins that use TruePVE's API, although this would require some kind of efficient state management/modeling (maybe a dictionary of resolved modes per plugin or something), since it would probably have to do a minimal state check on every hook call? Edit: Or just implement a hook call in DPVP & PBPZ OnServerInitialized() to advertise use of TruePVE's API, so that SPI can unsubscribe once and not worry about it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions