From ae48e5effbb26caacbb3352501f61a55bd462dfc Mon Sep 17 00:00:00 2001 From: zone-zero Date: Tue, 15 Jun 2021 19:01:27 -0400 Subject: [PATCH 1/2] Update http_transformation.py check if transform exists before deleting. --- ibmsecurity/isam/web/http_transformation.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ibmsecurity/isam/web/http_transformation.py b/ibmsecurity/isam/web/http_transformation.py index c21b1823..cfccdbfa 100644 --- a/ibmsecurity/isam/web/http_transformation.py +++ b/ibmsecurity/isam/web/http_transformation.py @@ -53,6 +53,10 @@ def delete(isamAppliance, id, check_mode=False, force=False): """ Deleting a HTTP Transformation """ + ret_obj_content = get(isamAppliance, id) + if ret_obj_content['data'] == {}: + return isamAppliance.create_return_object(changed=False) + if force is True or _check(isamAppliance, id) is True: if check_mode is True: return isamAppliance.create_return_object(changed=True) From b5396cba55ae230e8191f50cc0657acf352a9ca2 Mon Sep 17 00:00:00 2001 From: Kennison Martin Date: Tue, 15 Jun 2021 19:47:04 -0400 Subject: [PATCH 2/2] update http_transformation.py changed to get_all method to see if transform exists before deleting --- ibmsecurity/isam/web/http_transformation.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ibmsecurity/isam/web/http_transformation.py b/ibmsecurity/isam/web/http_transformation.py index cfccdbfa..c3fa986e 100644 --- a/ibmsecurity/isam/web/http_transformation.py +++ b/ibmsecurity/isam/web/http_transformation.py @@ -53,8 +53,10 @@ def delete(isamAppliance, id, check_mode=False, force=False): """ Deleting a HTTP Transformation """ - ret_obj_content = get(isamAppliance, id) - if ret_obj_content['data'] == {}: + #check if transformation exists before deleting + # use get_all and search result because get errors with 404 if transform doesn't exist + ret_obj_content = get_all(isamAppliance) + if not next((item for item in ret_obj_content['data'] if item["id"] == id), None): return isamAppliance.create_return_object(changed=False) if force is True or _check(isamAppliance, id) is True: