From 995867f17f65f83b666cbcde5b274efe83f50086 Mon Sep 17 00:00:00 2001
From: iszmais <iszmais@databay.de>
Date: Mon, 12 Jan 2026 15:08:41 +0100
Subject: [PATCH] Remove empty properties from groups and courses

---
 .../classes/class.ilObjCourseListGUI.php      | 10 ++---
 .../Group/classes/class.ilObjGroupAccess.php  | 12 ++----
 .../Group/classes/class.ilObjGroupListGUI.php | 42 ++++++++-----------
 .../Object/classes/class.ilObjectListGUI.php  |  1 +
 4 files changed, 26 insertions(+), 39 deletions(-)

diff --git a/Modules/Course/classes/class.ilObjCourseListGUI.php b/Modules/Course/classes/class.ilObjCourseListGUI.php
index 3f10d2802005..60a57396a3b9 100644
--- a/Modules/Course/classes/class.ilObjCourseListGUI.php
+++ b/Modules/Course/classes/class.ilObjCourseListGUI.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=0);
-
 /**
  * This file is part of ILIAS, a powerful learning management system
  * published by ILIAS open source e-Learning e.V.
@@ -18,6 +16,8 @@
  *
  *********************************************************************/
 
+declare(strict_types=0);
+
 /**
  * Class ilObjCourseListGUI
  * @author  Alex Killing <alex.killing@gmx.de>
@@ -143,12 +143,12 @@ public function getProperties(): array
 
         // course period
         $info = ilObjCourseAccess::lookupPeriodInfo($this->obj_id);
-        if (is_array($info)) {
+        if ($info !== []) {
             $props[] = array(
                 'alert' => false,
                 'newline' => true,
-                'property' => $info['property'] ?? "",
-                'value' => $info['value'] ?? ""
+                'property' => $info['property'],
+                'value' => $info['value']
             );
         }
 
diff --git a/Modules/Group/classes/class.ilObjGroupAccess.php b/Modules/Group/classes/class.ilObjGroupAccess.php
index 852f445e5f47..afeb9788f42e 100644
--- a/Modules/Group/classes/class.ilObjGroupAccess.php
+++ b/Modules/Group/classes/class.ilObjGroupAccess.php
@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * This file is part of ILIAS, a powerful learning management system
  * published by ILIAS open source e-Learning e.V.
@@ -18,6 +16,7 @@
  *
  *********************************************************************/
 
+declare(strict_types=1);
 
 /**
 * Class ilObjGroupAccess
@@ -282,12 +281,7 @@ public static function lookupRegistrationInfo(int $a_obj_id): array
         return $info;
     }
 
-    /**
-     * @param int $a_obj_id
-     * @return array<{property: string, value: string}> | null
-     * @throws ilDateTimeException
-     */
-    public static function lookupPeriodInfo(int $a_obj_id): ?array
+    public static function lookupPeriodInfo(int $a_obj_id): array
     {
         global $DIC;
 
@@ -325,7 +319,7 @@ public static function lookupPeriodInfo(int $a_obj_id): ?array
                     'value' => ilDatePresentation::formatPeriod($start, $end)
                 ];
         }
-        return null;
+        return [];
     }
 
     public static function _usingRegistrationCode(): bool
diff --git a/Modules/Group/classes/class.ilObjGroupListGUI.php b/Modules/Group/classes/class.ilObjGroupListGUI.php
index 4a2dc5d9849c..97813bc821fc 100644
--- a/Modules/Group/classes/class.ilObjGroupListGUI.php
+++ b/Modules/Group/classes/class.ilObjGroupListGUI.php
@@ -1,29 +1,22 @@
 <?php
 
-declare(strict_types=1);
-/*
-    +-----------------------------------------------------------------------------+
-    | ILIAS open source                                                           |
-    +-----------------------------------------------------------------------------+
-    | Copyright (c) 1998-2008 ILIAS open source, University of Cologne            |
-    |                                                                             |
-    | This program is free software; you can redistribute it and/or               |
-    | modify it under the terms of the GNU General Public License                 |
-    | as published by the Free Software Foundation; either version 2              |
-    | of the License, or (at your option) any later version.                      |
-    |                                                                             |
-    | This program is distributed in the hope that it will be useful,             |
-    | but WITHOUT ANY WARRANTY; without even the implied warranty of              |
-    | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               |
-    | GNU General Public License for more details.                                |
-    |                                                                             |
-    | You should have received a copy of the GNU General Public License           |
-    | along with this program; if not, write to the Free Software                 |
-    | Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA. |
-    +-----------------------------------------------------------------------------+
-*/
-
+/**
+ * This file is part of ILIAS, a powerful learning management system
+ * published by ILIAS open source e-Learning e.V.
+ *
+ * ILIAS is licensed with the GPL-3.0,
+ * see https://www.gnu.org/licenses/gpl-3.0.en.html
+ * You should have received a copy of said license along with the
+ * source code, too.
+ *
+ * If this is not the case or you just want to try ILIAS, you'll find
+ * us at:
+ * https://www.ilias.de
+ * https://github.com/ILIAS-eLearning
+ *
+ *********************************************************************/
 
+declare(strict_types=1);
 
 /**
 * Class ilObjGroupListGUI
@@ -132,9 +125,8 @@ public function getProperties(): array
             );
         }
 
-        // course period
         $info = ilObjGroupAccess::lookupPeriodInfo($this->obj_id);
-        if (is_array($info)) {
+        if ($info !== []) {
             $props[] = array(
                 'alert' => false,
                 'newline' => true,
diff --git a/Services/Object/classes/class.ilObjectListGUI.php b/Services/Object/classes/class.ilObjectListGUI.php
index 41487cb5ea8e..2322472d1f30 100644
--- a/Services/Object/classes/class.ilObjectListGUI.php
+++ b/Services/Object/classes/class.ilObjectListGUI.php
@@ -1284,6 +1284,7 @@ public function determineProperties(): array
                 if (!$this->access->checkAccess('read', '', $this->ref_id, $this->type, $this->obj_id)) {
                     $props[] = [
                         'alert' => true,
+                        'property' => '',
                         'value' => $this->lng->txt('no_access_item_public'),
                         'newline' => true
                     ];