From 9e84df94bead84627503bbc76edd6dadbaf3eb8a Mon Sep 17 00:00:00 2001 From: Henrik Hose Date: Tue, 10 Feb 2026 11:41:02 +0100 Subject: [PATCH 1/6] fixed Boost::system include for Boost >= 1.89 --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1f85edc..56efcd8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -18,7 +18,7 @@ set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_EXTENSIONS OFF) -find_package(Boost 1.5 COMPONENTS system REQUIRED) # for optitrack +find_package(Boost 1.5 REQUIRED) # for optitrack add_definitions( -DBOOST_DATE_TIME_NO_LIB -DBOOST_REGEX_NO_LIB @@ -87,7 +87,7 @@ if (LIBMOTIONCAPTURE_ENABLE_OPTITRACK) ) set(my_libraries ${my_libraries} - Boost::system + Boost::boost ) endif() From 49a741de0447530d83014b406f0a27b0462d01e7 Mon Sep 17 00:00:00 2001 From: Henrik Hose Date: Wed, 11 Feb 2026 11:46:30 +0100 Subject: [PATCH 2/6] fixing Linux CI pthread linker error --- CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 56efcd8..aeb8c38 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -6,7 +6,7 @@ option(LIBMOTIONCAPTURE_BUILD_PYTHON_BINDINGS "Generate Python Bindings" ON) option(LIBMOTIONCAPTURE_ENABLE_QUALISYS "Enable Qualisys" OFF) option(LIBMOTIONCAPTURE_ENABLE_OPTITRACK "Enable Optitrack" ON) option(LIBMOTIONCAPTURE_ENABLE_OPTITRACK_CLOSED_SOURCE "Enable Optitrack (Closed Source)" OFF) -option(LIBMOTIONCAPTURE_ENABLE_VICON "Enable Vicon" OFF) +option(LIBMOTIONCAPTURE_ENABLE_VICON "Enable Vicon" ON) option(LIBMOTIONCAPTURE_ENABLE_NOKOV "Enable Nokov" OFF) option(LIBMOTIONCAPTURE_ENABLE_VRPN "Enable VRPN" OFF) option(LIBMOTIONCAPTURE_ENABLE_FZMOTION "Enable FZMOTION" OFF) @@ -18,6 +18,8 @@ set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_EXTENSIONS OFF) +find_package(Threads REQUIRED) + find_package(Boost 1.5 REQUIRED) # for optitrack add_definitions( -DBOOST_DATE_TIME_NO_LIB @@ -88,6 +90,7 @@ if (LIBMOTIONCAPTURE_ENABLE_OPTITRACK) set(my_libraries ${my_libraries} Boost::boost + Threads::Threads ) endif() From 92459d9da4c211951e50a3b72229ce095a859acd Mon Sep 17 00:00:00 2001 From: Henrik Hose Date: Wed, 11 Feb 2026 11:46:51 +0100 Subject: [PATCH 3/6] fixing windows CI Eigen include error --- setup.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/setup.py b/setup.py index 8094014..305fe9b 100644 --- a/setup.py +++ b/setup.py @@ -45,6 +45,11 @@ def build_extension(self, ext): "-DCMAKE_BUILD_TYPE={}".format(cfg), # not used on MSVC, but no harm "-DCMAKE_POLICY_VERSION_MINIMUM=3.5" # to make sure vrpn compiles ] + + # Add CMAKE_TOOLCHAIN_FILE for vcpkg on Windows + if "CMAKE_TOOLCHAIN_FILE" in os.environ: + cmake_args += ["-DCMAKE_TOOLCHAIN_FILE={}".format(os.environ["CMAKE_TOOLCHAIN_FILE"])] + build_args = [] if self.compiler.compiler_type != "msvc": From 530bd0e4f8109bd1d4ecbedbd105e8e132799bab Mon Sep 17 00:00:00 2001 From: Henrik Hose Date: Wed, 11 Feb 2026 11:47:18 +0100 Subject: [PATCH 4/6] adding Python 3.14 to CI --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 09d35b4..dcefc6d 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -46,7 +46,7 @@ jobs: strategy: matrix: # active versions: https://devguide.python.org/versions/ - python: ['3.9', '3.10', '3.11', '3.12', '3.13'] + python: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] steps: - uses: actions/checkout@v3 @@ -75,7 +75,7 @@ jobs: strategy: matrix: # active versions: https://devguide.python.org/versions/ - python: ['3.9', '3.10', '3.11', '3.12', '3.13'] + python: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] steps: - uses: actions/checkout@v3 @@ -110,7 +110,7 @@ jobs: strategy: matrix: # active versions: https://devguide.python.org/versions/ - python: ['3.9', '3.10', '3.11', '3.12', '3.13'] + python: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14'] steps: - uses: actions/checkout@v3 From cac557e06b6afdc8316d372c34c8f05df0055d02 Mon Sep 17 00:00:00 2001 From: Henrik Hose Date: Tue, 17 Feb 2026 11:46:29 +0100 Subject: [PATCH 5/6] bump vicon sdk version to boost>=1.89 fix --- deps/vicon-datastream-sdk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/vicon-datastream-sdk b/deps/vicon-datastream-sdk index a21c9c8..a5096f2 160000 --- a/deps/vicon-datastream-sdk +++ b/deps/vicon-datastream-sdk @@ -1 +1 @@ -Subproject commit a21c9c8e5fd797e4833e19b78ad310d857c2f6c1 +Subproject commit a5096f283f484acca98b434c08810cd922551701 From aab4751225bc2a15e5b17bdb44724d2d731a2f6f Mon Sep 17 00:00:00 2001 From: Henrik Hose Date: Tue, 17 Feb 2026 11:55:47 +0100 Subject: [PATCH 6/6] Messing with Eigen3 include to fix Win CI --- CMakeLists.txt | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index aeb8c38..7bc2cf5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -29,6 +29,15 @@ add_definitions( find_package(Eigen3 REQUIRED) +# Handle both old and new Eigen3 package configurations +if(NOT TARGET Eigen3::Eigen) + # Old-style Eigen3 package - create interface target + add_library(Eigen3::Eigen INTERFACE IMPORTED) + set_target_properties(Eigen3::Eigen PROPERTIES + INTERFACE_INCLUDE_DIRECTORIES "${EIGEN3_INCLUDE_DIR};${EIGEN3_INCLUDE_DIRS}" + ) +endif() + set(VICON_SDK_DIR ${CMAKE_CURRENT_SOURCE_DIR}/deps/vicon-datastream-sdk/) set(QUALISYS_DIR ${CMAKE_CURRENT_SOURCE_DIR}/deps/qualisys_cpp_sdk/) set(NATNET_SDK_DIR ${CMAKE_CURRENT_SOURCE_DIR}/deps/NatNetSDKCrossplatform/) @@ -235,7 +244,10 @@ target_link_directories(libmotioncapture PUBLIC ${my_link_directories} ) target_link_libraries(libmotioncapture - ${my_libraries} + PUBLIC + Eigen3::Eigen + PRIVATE + ${my_libraries} ) set_property(TARGET libmotioncapture PROPERTY POSITION_INDEPENDENT_CODE ON)