From e7a386a157740bd68ded5568334c38124d9681cd Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Fri, 6 Mar 2020 10:13:25 -0600 Subject: [PATCH 1/2] browser testing --- PULL_REQUEST_TEMPLATE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index da70b91..27198dd 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -20,7 +20,10 @@ Features that this PR affects: Questions that need to be answered before merging: - [ ] Is this PR targeting the correct branch in this repository? -- [ ] +- [ ] Has this been tested in the following browsers: + - [ ] Chrome (covers IE Edgeium) + - [ ] Safari (the new IE) + - [ ] Firefox (the non-Webkit option) Steps to test this PR: From 5f2a859831ea0ef601612b7c1a86a19ae9c66a7b Mon Sep 17 00:00:00 2001 From: Ben Keith Date: Tue, 28 Apr 2020 16:27:23 -0400 Subject: [PATCH 2/2] Improve question template, add q for changelog, remove Safari commentary --- PULL_REQUEST_TEMPLATE.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 27198dd..9f105c8 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -16,13 +16,14 @@ Features that this PR affects: - - -Questions that need to be answered before merging: + +Questions that may need to be answered before merging: - [ ] Is this PR targeting the correct branch in this repository? -- [ ] Has this been tested in the following browsers: +- [ ] Does this file update the relevant changelogs with a description of what's changed? +- [ ] If this is a frontend change, has this been tested in the following browsers? - [ ] Chrome (covers IE Edgeium) - - [ ] Safari (the new IE) + - [ ] Safari - [ ] Firefox (the non-Webkit option) Steps to test this PR: