TransportClientBuilder.buildFor does not consider role

[atschabu]

We have an integration with a partner that provides different endpoints for roles receiver and sender. Therefore the buildFor fails to select the right url if the wrong role is first in the list.

For example as eMSP calling the SENDER endpoint will fail if RECEIVER is defined first

{
"url": "https://some.partner/emsp/2.2.1/locations",
"role": "RECEIVER",
"identifier": "locations"
},
{
"url": "https://some.partner/cpo/2.2.1/locations",
"role": "SENDER",
"identifier": "locations"
},

This also brings back the question around the usefulness of having transport in a different module #111 , given how tightly coupled it is with the protocol. There are too many non-overrridable extensions inside the toolkit.common that would be better served being in an abstract class

[lilgallon]

I've started seeing this issue in a personal project too. I agree, it will become a problem for us within a few months as well.