Skip to content
This repository was archived by the owner on Apr 25, 2019. It is now read-only.

Request: Add error property to FPMediaInfo #119

@newyorkpizza

Description

@newyorkpizza

If an error occurs during media upload, there is no direct way for my app to detect that an error has occurred.

Instead, we infer that an error has occurred by checking the info parameter for the delegate method - (void)fpPickerController:(FPPickerController *)picker didFinishPickingMediaWithInfo:(FPMediaInfo *)info. If info.remoteURL, info.filename, or info.mediaType is nil, then we know that the upload was unsuccessful.

However, it would be cleaner if the FilePicker API were to explicitly indicate that an error has occurred. It would also be useful if the API returned the NSError.

A possible solution would be to add a new property to FPMediaInfo for an NSError. Then, the connection error could be set on mediaInfo, i.e.:

    mediaInfo.error = error;
    failure(error, mediaInfo);

at these two lines:

failure(error, mediaInfo);

failure(error, mediaInfo);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions