So basically dns.lookup() has always had an option named all which if set to true would have the lookup return an array of address+family objects. From the docs:

With the all option set to true, the arguments for callback change to (err, addresses), with addresses being an array of objects with the properties address and family.

Evil-dns just returns a single object regardless, so this would have been an existing bug for anything calling with options.all=true.

However in Node 20 this got more visible, as the core net code now includes options.all=true by default which makes it into all sort of things. (Like Got via core http client which then uses net, etc). So it becomes an issue with most calls.

In the end the answer is to check for that option and return as an array if needed.

Going from:

return process.nextTick(() => callback(null, entry.ip, entry.family));

To:

if (typeof(options) === 'object' && options.all) {
  return process.nextTick(() => callback(null, [{address: entry.ip, family: entry.family}]));
}
else return process.nextTick(() => callback(null, entry.ip, entry.family));

Node v20 support #7

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions