Skip to content

Remove redundant pyproject.toml existence checks #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove redundant pyproject.toml existence checks #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96f110a
Initial plan
Copilot Dec 26, 2025
5440398
Remove redundant pyproject.toml existence checks from bump and releas…
Copilot Dec 26, 2025
18f4217
Remove redundant pyproject.toml existence checks from Makefile
Copilot Dec 26, 2025
53720a2
Add clarifying comment about pyproject.toml assumption in Makefile
Copilot Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .rhiza/scripts/bump.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ TYPE=""
DO_COMMIT=""
COMMIT_MSG=""

# Check if pyproject.toml exists
if [ ! -f "pyproject.toml" ]; then
printf "%b[ERROR] pyproject.toml not found in current directory%b\n" "$RED" "$RESET"
exit 1
fi

# Check if uv is available
if [ ! -x "$UV_BIN" ]; then
printf "%b[ERROR] uv not found at %s. Run 'make install-uv' first.%b\n" "$RED" "$UV_BIN" "$RESET"
Expand Down
6 changes: 0 additions & 6 deletions .rhiza/scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,6 @@ while [ $# -gt 0 ]; do
esac
done

# Check if pyproject.toml exists
if [ ! -f "pyproject.toml" ]; then
printf "%b[ERROR] pyproject.toml not found in current directory%b\n" "$RED" "$RESET"
exit 1
fi

# Check if uv is available
if [ ! -x "$UV_BIN" ]; then
printf "%b[ERROR] uv not found at %s. Run 'make install-uv' first.%b\n" "$RED" "$UV_BIN" "$RESET"
Expand Down
25 changes: 9 additions & 16 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,14 @@ install: install-uv install-extras ## install
${UV_BIN} pip install -r tests/requirements.txt || { printf "${RED}[ERROR] Failed to install test requirements${RESET}\n"; exit 1; }; \
fi

# Install the dependencies from pyproject.toml (if it exists)
@if [ -f "pyproject.toml" ]; then \
if [ -f "uv.lock" ]; then \
printf "${BLUE}[INFO] Installing dependencies from lock file${RESET}\n"; \
${UV_BIN} sync --all-extras --frozen || { printf "${RED}[ERROR] Failed to install dependencies${RESET}\n"; exit 1; }; \
else \
printf "${YELLOW}[WARN] uv.lock not found. Generating lock file and installing dependencies...${RESET}\n"; \
${UV_BIN} sync --all-extras || { printf "${RED}[ERROR] Failed to install dependencies${RESET}\n"; exit 1; }; \
fi; \
# Install dependencies from pyproject.toml
# Note: pyproject.toml is assumed to exist (validation would fail otherwise)
@if [ -f "uv.lock" ]; then \
printf "${BLUE}[INFO] Installing dependencies from lock file${RESET}\n"; \
${UV_BIN} sync --all-extras --frozen || { printf "${RED}[ERROR] Failed to install dependencies${RESET}\n"; exit 1; }; \
else \
printf "${YELLOW}[WARN] No pyproject.toml found, skipping install${RESET}\n"; \
printf "${YELLOW}[WARN] uv.lock not found. Generating lock file and installing dependencies...${RESET}\n"; \
${UV_BIN} sync --all-extras || { printf "${RED}[ERROR] Failed to install dependencies${RESET}\n"; exit 1; }; \
fi

sync: install-uv ## sync with template repository as defined in .github/template.yml
Expand Down Expand Up @@ -129,12 +126,8 @@ marimo: install ## fire up Marimo server
fi

##@ Quality and Formatting
deptry: install-uv ## run deptry if pyproject.toml exists
@if [ -f "pyproject.toml" ]; then \
${UVX_BIN} deptry "${SOURCE_FOLDER}"; \
else \
printf "${YELLOW} No pyproject.toml found, skipping deptry${RESET}\n"; \
fi
deptry: install-uv ## run deptry
@${UVX_BIN} deptry "${SOURCE_FOLDER}"

fmt: install-uv ## check the pre-commit hooks and the linting
@${UVX_BIN} pre-commit run --all-files
Expand Down