From e44a1a2b4ff674db7afbb0b2f0e03a139dfcc3c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9C=A8=E7=93=9C?= Date: Thu, 22 Aug 2019 11:37:53 +0800 Subject: [PATCH] fix shouldBeginGestureHandler be empty and cause a crash --- Source/SwiftyStarRatingView.swift | 5 +++-- .../xcshareddata/IDEWorkspaceChecks.plist | 8 ++++++++ 2 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 SwiftyStarRatingView.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist diff --git a/Source/SwiftyStarRatingView.swift b/Source/SwiftyStarRatingView.swift index 7633a91..681276c 100644 --- a/Source/SwiftyStarRatingView.swift +++ b/Source/SwiftyStarRatingView.swift @@ -14,7 +14,7 @@ public typealias SSRVGestureHandler = (_ gesture: UIGestureRecognizer) -> Bool public class SwiftyStarRatingView: UIControl { public var shouldBecomeFirstResponder: Bool = false - public var shouldBeginGestureHandler: SSRVGestureHandler! + public var shouldBeginGestureHandler: SSRVGestureHandler? fileprivate var _minimumValue: CGFloat = 0 fileprivate var _maximumValue: CGFloat = 5 @@ -310,7 +310,8 @@ extension SwiftyStarRatingView { if let gestureView = gestureRecognizer.view, gestureView.isEqual(self) { return !self.isUserInteractionEnabled } else { - return self.shouldBeginGestureHandler(gestureRecognizer) + guard let handle = self.shouldBeginGestureHandler else { return false } + return handle(gestureRecognizer) } } diff --git a/SwiftyStarRatingView.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/SwiftyStarRatingView.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist new file mode 100644 index 0000000..18d9810 --- /dev/null +++ b/SwiftyStarRatingView.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist @@ -0,0 +1,8 @@ + + + + + IDEDidComputeMac32BitWarning + + +