Skip to content

Fall back to GPUArrays 1.12 handling #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshyatt wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −7
Open

Fall back to GPUArrays 1.12 handling #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c621696
Fall back to GPUArrays 1.12 handling
kshyatt Jan 9, 2026
ca9f1d1
Actually fall back properly
kshyatt Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ CEnum = "0.4, 0.5"
ChainRulesCore = "1"
EnzymeCore = "0.8"
ExprTools = "0.1"
GPUArrays = "11.3.1"
GPUArrays = "11.3.4"
GPUCompiler = "1"
GPUToolbox = "0.1.0, 0.2, 0.3, 1"
KernelAbstractions = "0.9.2"
Expand Down
7 changes: 1 addition & 6 deletions src/blas/highlevel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ rocblas_size(t::Char, M::ROCVecOrMat) = (size(M, t=='N' ? 1 : 2), size(M, t=='N'

@static if VERSION ≥ v"1.12.0-rc"
# we need to use the generic wrapper to avoid dispatch to the 2x2or3x3 method
using LinearAlgebra: generic_matmatmul_wrapper!, BlasFlag, _symm_hemm_generic!
using LinearAlgebra: BlasFlag, _symm_hemm_generic!
end

#
Expand Down Expand Up @@ -165,11 +165,6 @@ end
#

@static if VERSION ≥ v"1.12.0-rc"
function LinearAlgebra.generic_matmatmul_wrapper!(
C::StridedROCMatrix{T}, tA::AbstractChar, tB::AbstractChar, A::StridedROCVecOrMat{T}, B::StridedROCVecOrMat{T},
alpha::Number, beta::Number, val::LinearAlgebra.BlasFlag.SyrkHerkGemm) where {T<:ROCBLASFloat}
LinearAlgebra.generic_matmatmul!(C, tA, tB, A, B, alpha, beta)
end
function LinearAlgebra._symm_hemm_generic!(
C::StridedROCMatrix{T}, tA::AbstractChar, tB::AbstractChar, A::StridedROCMatrix{T}, B::StridedROCMatrix{T},
alpha, beta, ::Val{BlasFlag.SYMM}) where {T}
Expand Down