Skip to content

Revert "Allow semi-concrete interpretation"#760

Merged
maleadt merged 1 commit intomasterfrom
revert-750-tb/semiconcrete
Jan 27, 2026
Merged

Revert "Allow semi-concrete interpretation"#760
maleadt merged 1 commit intomasterfrom
revert-750-tb/semiconcrete

Conversation

@christiangnrd
Copy link
Member

Reverts #750

This should fix #761, and #663 (comment) until a proper fix can be identified.

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/jlgen.jl b/src/jlgen.jl
index d6116cb..5715df2 100644
--- a/src/jlgen.jl
+++ b/src/jlgen.jl
@@ -502,21 +502,29 @@ end
 CC.method_table(interp::GPUInterpreter) = interp.method_table_view
 
 # semi-concrete interepretation is broken with overlays (JuliaLang/julia#47349)
-function CC.concrete_eval_eligible(interp::GPUInterpreter,
-    @nospecialize(f), result::CC.MethodCallResult, arginfo::CC.ArgInfo, sv::CC.InferenceState)
+function CC.concrete_eval_eligible(
+        interp::GPUInterpreter,
+        @nospecialize(f), result::CC.MethodCallResult, arginfo::CC.ArgInfo, sv::CC.InferenceState
+    )
     # NOTE it's fine to skip overloading with `sv::IRInterpretationState` since we disables
     #      semi-concrete interpretation anyway.
-    ret = @invoke CC.concrete_eval_eligible(interp::CC.AbstractInterpreter,
-        f::Any, result::CC.MethodCallResult, arginfo::CC.ArgInfo, sv::CC.InferenceState)
+    ret = @invoke CC.concrete_eval_eligible(
+        interp::CC.AbstractInterpreter,
+        f::Any, result::CC.MethodCallResult, arginfo::CC.ArgInfo, sv::CC.InferenceState
+    )
     if ret === :semi_concrete_eval
         return :none
     end
     return ret
 end
-function CC.concrete_eval_eligible(interp::GPUInterpreter,
-    @nospecialize(f), result::CC.MethodCallResult, arginfo::CC.ArgInfo)
-    ret = @invoke CC.concrete_eval_eligible(interp::CC.AbstractInterpreter,
-        f::Any, result::CC.MethodCallResult, arginfo::CC.ArgInfo)
+function CC.concrete_eval_eligible(
+        interp::GPUInterpreter,
+        @nospecialize(f), result::CC.MethodCallResult, arginfo::CC.ArgInfo
+    )
+    ret = @invoke CC.concrete_eval_eligible(
+        interp::CC.AbstractInterpreter,
+        f::Any, result::CC.MethodCallResult, arginfo::CC.ArgInfo
+    )
     ret === false && return nothing
     return ret
 end

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.79%. Comparing base (4e5ffed) to head (657777f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/jlgen.jl 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   74.97%   74.79%   -0.18%     
==========================================
  Files          24       24              
  Lines        3764     3773       +9     
==========================================
  Hits         2822     2822              
- Misses        942      951       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt merged commit e93a121 into master Jan 27, 2026
32 of 38 checks passed
@maleadt maleadt deleted the revert-750-tb/semiconcrete branch January 27, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metal.jl sincos intrinsic produces invalid LLVM IR on Julia 1.11+ (GPUCompiler 1.7.6+)

2 participants