Skip to content

Support division between two ComplexF32 numbers #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertomercurio wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −0
Open

Support division between two ComplexF32 numbers #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/device/intrinsics/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,21 @@ end
@device_override Base.max(x::Float32, y::Float32, z::Float32) = ccall("extern air.fmax3.f32", llvmcall, Cfloat, (Cfloat, Cfloat, Cfloat), x, y, z)
@device_override Base.max(x::Float16, y::Float16, z::Float16) = ccall("extern air.fmax3.f16", llvmcall, Float16, (Float16, Float16, Float16), x, y, z)

@device_override function Base.:(/)(z::Complex{Float32}, w::Complex{Float32})
c, d = reim(w) # Avoid using widen(w) as in Base
a, b = reim(z) # Avoid using widen(z) as in Base
if (isinf(c) | isinf(d))
if isfinite(z)
return complex(zero(Float32)*sign(real(z))*sign(real(w)), -zero(Float32)*sign(imag(z))*sign(imag(w)))
end
return Float32(NaN)+Float32(NaN)*im
end
mag = inv(muladd(c, c, d^2))
re_part = muladd(a, c, b*d)
im_part = muladd(b, c, -a*d)
return oftype(z, Complex(re_part*mag, im_part*mag))
end

@device_override FastMath.acos_fast(x::Float32) = ccall("extern air.fast_acos.f32", llvmcall, Cfloat, (Cfloat,), x)
@device_override Base.acos(x::Float32) = ccall("extern air.acos.f32", llvmcall, Cfloat, (Cfloat,), x)
@device_override Base.acos(x::Float16) = ccall("extern air.acos.f16", llvmcall, Float16, (Float16,), x)
Expand Down
16 changes: 16 additions & 0 deletions test/device/intrinsics/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,22 @@ end
@test Array(mtlout) == clamp.(in, minval, maxval)
end

let
N = 10

x = rand(ComplexF32, N)
y = rand(ComplexF32, N)

dx = MtlArray(x)
dy = MtlArray(y)


z = x ./ y
dz = dx ./ dy

@test Array(dz) ≈ z
end

let #pow
N = 4
arr1 = rand(T, N)
Expand Down