Skip to content

Commit 5a705c4

Browse files
committed
Revert "Remove non-standard contextMenus.create"
This reverts commit ab19d0d. That was introduced in PR #26 as an alternative approach to #27. However with the more consistent solution of #27, `contextMenus.create` should be promisified, in order to ensure a consistent API (so it returns a Promise, like everything else).
1 parent c6d346c commit 5a705c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

chrome-extension-async.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
{ n: 'camera', props: knownInContentSetting },
156156
{ n: 'unsandboxedPlugins', props: knownInContentSetting },
157157
{ n: 'automaticDownloads', props: knownInContentSetting }],
158-
contextMenus: ['update', 'remove', 'removeAll'], /* 'create' omitted intentionally, it does not follow standard asynchronous pattern */
158+
contextMenus: ['create', 'update', 'remove', 'removeAll'],
159159
cookies: ['get', 'getAll', 'set', 'remove', 'getAllCookieStores'],
160160
debugger: ['attach', 'detach', 'sendCommand', 'getTargets'],
161161
desktopCapture: ['chooseDesktopMedia'],

0 commit comments

Comments
 (0)