Skip to content

Hardcoded "Bluemix" URLs #58

@christiancompton

Description

@christiancompton

In some places, bluemix.net is hardcoded. At the minimum, this must be upgraded to cloud.ibm.com, if not removed entirely.

PushSDKCredentials.swift - CloudEnvironment can be used on other cloud providers (esp given OpenShift will be coming…) but in this code I see “bluemix.net” hardcoded - is that supposed to be there?

   guard let host = url.host,
     host.hasSuffix(“.bluemix.net”)
   else{
     return nil
   }
   let parts = host.split(separator: “.”).suffix(3)
   guard parts.count > 2 && parts.first != “imfpush” else {
     return nil
   }
   return parts.joined(separator: “.”)
 }```

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions