diff --git a/src/code/fetch_utilities.py b/src/code/fetch_utilities.py index 23d70d6..d2f8834 100644 --- a/src/code/fetch_utilities.py +++ b/src/code/fetch_utilities.py @@ -102,7 +102,26 @@ def download(version_dict): while os.path.splitext(filename)[1] in ARCHIVES: if tarfile.is_tarfile(filename): with tarfile.open(filename) as tar: - tar.extractall(path=DIR) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=DIR) file_list = tar.getnames() elif zipfile.is_zipfile(filename): with zipfile.ZipFile(filename) as zfile: