diff --git a/packages/components/package-lock.json b/packages/components/package-lock.json index 98524082c8..976d2939e5 100644 --- a/packages/components/package-lock.json +++ b/packages/components/package-lock.json @@ -1,12 +1,12 @@ { "name": "@labkey/components", - "version": "6.53.2", + "version": "6.53.3", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@labkey/components", - "version": "6.53.2", + "version": "6.53.3", "license": "SEE LICENSE IN LICENSE.txt", "dependencies": { "@hello-pangea/dnd": "18.0.1", diff --git a/packages/components/package.json b/packages/components/package.json index b9be0f31e5..91753e4d0a 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@labkey/components", - "version": "6.53.2", + "version": "6.53.3", "description": "Components, models, actions, and utility functions for LabKey applications and pages", "sideEffects": false, "files": [ diff --git a/packages/components/releaseNotes/components.md b/packages/components/releaseNotes/components.md index d6db1cd6d0..8647e23ac6 100644 --- a/packages/components/releaseNotes/components.md +++ b/packages/components/releaseNotes/components.md @@ -1,6 +1,10 @@ # @labkey/components Components, models, actions, and utility functions for LabKey applications and pages +### version 6.53.3 +*Released*: 7 July 2025 +- Issue 53394: FileInput revert removal of the "-fileUpload" suffix from inputId + ### version 6.53.2 *Released*: 3 July 2025 * Issue 53141: Should set a dirty bit when setting or updating the hit selection criteria for an assay diff --git a/packages/components/src/internal/components/forms/input/FileInput.tsx b/packages/components/src/internal/components/forms/input/FileInput.tsx index a3374914d1..9e557cd9f3 100644 --- a/packages/components/src/internal/components/forms/input/FileInput.tsx +++ b/packages/components/src/internal/components/forms/input/FileInput.tsx @@ -199,7 +199,8 @@ class FileInputImpl extends DisableableInput { } = this.props; const { data, file, isDisabled, isHover } = this.state; - const inputId = this.getInputName(); + const name = this.getInputName(); + const inputId = `${name}-fileUpload`; // Issue 53394: needs to be a distinct input id so it doesn't collide with other elements on the page for this fieldKey let body; if (file) { @@ -209,10 +210,10 @@ class FileInputImpl extends DisableableInput { body = (
@@ -223,8 +224,8 @@ class FileInputImpl extends DisableableInput { } else if (data?.get('value')) { body = ( ); @@ -232,14 +233,14 @@ class FileInputImpl extends DisableableInput { body = ( <> {/* We render a label here so click and drag events propagate to the input above */} @@ -249,12 +250,12 @@ class FileInputImpl extends DisableableInput { 'file-upload__is-hover': isHover && !isDisabled, })} htmlFor={inputId} - onDrop={this.onDrop} onDragEnter={this.onDrag} - onDragOver={this.onDrag} onDragLeave={this.onDragLeave} + onDragOver={this.onDrag} + onDrop={this.onDrop} > -