From 2c22ef157237b6dd31803276a329a6e54bdb4cc2 Mon Sep 17 00:00:00 2001 From: XingY Date: Tue, 11 Nov 2025 19:18:48 -0800 Subject: [PATCH 1/3] Issue 54186: App actions for picklists and assay run delete don't get TransactionAuditEvent --- packages/components/package.json | 2 +- packages/components/releaseNotes/components.md | 5 +++++ .../components/src/internal/components/forms/actions.ts | 3 ++- .../src/internal/components/picklist/actions.ts | 8 ++++++-- .../components/samples/ManageSampleStatusesPanel.tsx | 5 +++++ 5 files changed, 19 insertions(+), 4 deletions(-) diff --git a/packages/components/package.json b/packages/components/package.json index 2307b705ba..b9383a114e 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@labkey/components", - "version": "6.70.3", + "version": "6.70.4-fb-issue54186.1", "description": "Components, models, actions, and utility functions for LabKey applications and pages", "sideEffects": false, "files": [ diff --git a/packages/components/releaseNotes/components.md b/packages/components/releaseNotes/components.md index 756ac810dc..991b60e838 100644 --- a/packages/components/releaseNotes/components.md +++ b/packages/components/releaseNotes/components.md @@ -1,6 +1,11 @@ # @labkey/components Components, models, actions, and utility functions for LabKey applications and pages +### version 6.X +*Released*: X November 2025 +- Issue 54186: App actions for picklists and assay run delete don't get TransactionAuditEvent + - Add 'auditBehavior' to insertRows, updateRows, deleteRows usages so app actions get TransactionAuditEvent + ### version 6.70.2 *Released*: 6 November 2025 - GridPanel diff --git a/packages/components/src/internal/components/forms/actions.ts b/packages/components/src/internal/components/forms/actions.ts index c6c4498c2e..e374cc63ff 100644 --- a/packages/components/src/internal/components/forms/actions.ts +++ b/packages/components/src/internal/components/forms/actions.ts @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { PermissionTypes, Security, User } from '@labkey/api'; +import { AuditBehaviorTypes, PermissionTypes, Security, User } from '@labkey/api'; import { useCallback, useEffect, useState } from 'react'; import { updateRows } from '../../query/api'; @@ -127,5 +127,6 @@ export function updateRowFieldValue(model: QueryModel, name: string, value: any) }, ], containerPath: model.containerPath, + auditBehavior: AuditBehaviorTypes.DETAILED, }); } diff --git a/packages/components/src/internal/components/picklist/actions.ts b/packages/components/src/internal/components/picklist/actions.ts index 26a103a8e3..bf8cd6d09a 100644 --- a/packages/components/src/internal/components/picklist/actions.ts +++ b/packages/components/src/internal/components/picklist/actions.ts @@ -1,4 +1,4 @@ -import { Domain, Filter, Query } from '@labkey/api'; +import { AuditBehaviorTypes, Domain, Filter, Query } from '@labkey/api'; import { List } from 'immutable'; @@ -220,7 +220,11 @@ export async function addSamplesToPicklist(listName: string, sampleIds: number[] const schemaQuery = new SchemaQuery(SCHEMAS.PICKLIST_TABLES.SCHEMA, listName); if (rows.size > 0) { - return await insertRows({ schemaQuery, rows }); + return await insertRows({ + schemaQuery, + rows, + auditBehavior: AuditBehaviorTypes.DETAILED, + }); } return new QueryCommandResponse({ diff --git a/packages/components/src/internal/components/samples/ManageSampleStatusesPanel.tsx b/packages/components/src/internal/components/samples/ManageSampleStatusesPanel.tsx index c429244a6b..5b14be94b1 100644 --- a/packages/components/src/internal/components/samples/ManageSampleStatusesPanel.tsx +++ b/packages/components/src/internal/components/samples/ManageSampleStatusesPanel.tsx @@ -1,6 +1,8 @@ import React, { FC, memo, useCallback, useEffect, useMemo, useState } from 'react'; import { List } from 'immutable'; +import { AuditBehaviorTypes } from '@labkey/api'; + import { LoadingSpinner } from '../base/LoadingSpinner'; import { Alert } from '../base/Alert'; import { LockIcon } from '../base/LockIcon'; @@ -157,6 +159,7 @@ export const SampleStatusDetail: FC = memo(props => { schemaQuery: SCHEMAS.CORE_TABLES.DATA_STATES, rows: [stateToSave], containerPath: container?.path, + auditBehavior: AuditBehaviorTypes.DETAILED, }) .then(() => { onActionComplete(stateToSave.label); @@ -171,6 +174,7 @@ export const SampleStatusDetail: FC = memo(props => { schemaQuery: SCHEMAS.CORE_TABLES.DATA_STATES, rows: List([stateToSave]), containerPath: container?.path, + auditBehavior: AuditBehaviorTypes.DETAILED, }) .then(() => { onActionComplete(stateToSave.label); @@ -192,6 +196,7 @@ export const SampleStatusDetail: FC = memo(props => { schemaQuery: SCHEMAS.CORE_TABLES.DATA_STATES, containerPath: container?.path, rows: [updatedState], + auditBehavior: AuditBehaviorTypes.DETAILED, }) .then(() => { onActionComplete(undefined, true); From 02cad441f70f69e7aecb646156ef84199f995298 Mon Sep 17 00:00:00 2001 From: XingY Date: Tue, 11 Nov 2025 20:26:32 -0800 Subject: [PATCH 2/3] Issue 54186: App actions for picklists and assay run delete don't get TransactionAuditEvent --- packages/components/package-lock.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/package-lock.json b/packages/components/package-lock.json index 293398d0e4..2b1ee4d4f1 100644 --- a/packages/components/package-lock.json +++ b/packages/components/package-lock.json @@ -1,12 +1,12 @@ { "name": "@labkey/components", - "version": "6.70.3", + "version": "6.70.4-fb-issue54186.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@labkey/components", - "version": "6.70.3", + "version": "6.70.4-fb-issue54186.1", "license": "SEE LICENSE IN LICENSE.txt", "dependencies": { "@hello-pangea/dnd": "18.0.1", From a513505db5cc1af2dd50d4b1f6d2fb7d3d958477 Mon Sep 17 00:00:00 2001 From: XingY Date: Thu, 13 Nov 2025 11:51:55 -0800 Subject: [PATCH 3/3] publish --- packages/components/package-lock.json | 4 ++-- packages/components/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/components/package-lock.json b/packages/components/package-lock.json index f160c030da..5804df043c 100644 --- a/packages/components/package-lock.json +++ b/packages/components/package-lock.json @@ -1,12 +1,12 @@ { "name": "@labkey/components", - "version": "6.70.4", + "version": "6.70.5", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@labkey/components", - "version": "6.70.4", + "version": "6.70.5", "license": "SEE LICENSE IN LICENSE.txt", "dependencies": { "@hello-pangea/dnd": "18.0.1", diff --git a/packages/components/package.json b/packages/components/package.json index 34f1344cc5..b156cc69c9 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@labkey/components", - "version": "6.70.5-fb-issue54186.1", + "version": "6.70.5", "description": "Components, models, actions, and utility functions for LabKey applications and pages", "sideEffects": false, "files": [