From 2ea374a60850da761d7e59d1fed55b83d384142a Mon Sep 17 00:00:00 2001 From: Lum Date: Tue, 26 Aug 2025 11:25:24 -0700 Subject: [PATCH] fix and regression for 53713 --- issues/src/org/labkey/issue/IssueServiceImpl.java | 4 ++-- issues/src/org/labkey/issue/actions/IssueValidation.java | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/issues/src/org/labkey/issue/IssueServiceImpl.java b/issues/src/org/labkey/issue/IssueServiceImpl.java index cbe0f4deac7..d8520606705 100644 --- a/issues/src/org/labkey/issue/IssueServiceImpl.java +++ b/issues/src/org/labkey/issue/IssueServiceImpl.java @@ -282,8 +282,8 @@ public void validateIssue(Container container, User user, Issue issue, Issue.act IssueValidation.validateRequiredFields(issueListDef, ccc, issueObject, user, errors); IssueValidation.validateNotifyList(issueObject, errors); // don't validate the assigned to field if we are in the process - // of closing it and we are assigning it to the guest user (otherwise validate) - if (action != Issue.action.close || UserManager.getGuestUser().getUserId() != issueObject.getAssignedTo()) + // of closing it + if (action != Issue.action.close) { IssueValidation.validateAssignedTo(issueObject, container, errors); } diff --git a/issues/src/org/labkey/issue/actions/IssueValidation.java b/issues/src/org/labkey/issue/actions/IssueValidation.java index bac035bcd36..fb6c47de5bf 100644 --- a/issues/src/org/labkey/issue/actions/IssueValidation.java +++ b/issues/src/org/labkey/issue/actions/IssueValidation.java @@ -173,6 +173,10 @@ public static void validateAssignedTo(Issue issue, Container container, Errors e if (userId != null) { User user = UserManager.getUser(userId); + // ignore if we are assigning to the guest user + if (user != null && user.isGuest()) + return; + // TODO: consider exposing IssueManager.canAssignTo if (user == null || !user.isActive() || !container.hasPermission(user, UpdatePermission.class)) errors.reject(SpringActionController.ERROR_MSG, "An invalid user was set for the Assigned To");