From a8689361abc1ca4eeac31fbd5033b96d0e9052df Mon Sep 17 00:00:00 2001 From: cnathe Date: Tue, 18 Nov 2025 09:31:29 -0600 Subject: [PATCH 1/2] Add/update links for the GitHub issues in /kanban/issues --- assay/src/org/labkey/assay/AssayManager.java | 2 +- .../schemas/dbscripts/postgresql/exp-25.002-25.003.sql | 2 +- .../resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql | 2 +- .../org/labkey/experiment/api/property/DomainPropertyImpl.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/assay/src/org/labkey/assay/AssayManager.java b/assay/src/org/labkey/assay/AssayManager.java index 5c901c8c27c..a5cc9435b36 100644 --- a/assay/src/org/labkey/assay/AssayManager.java +++ b/assay/src/org/labkey/assay/AssayManager.java @@ -421,7 +421,7 @@ public AssaySchema createSchema(User user, Container container, @Nullable Contai List allProtocols = getAssayProtocols(container); for (ExpProtocol protocol : allProtocols) { - if (name.equalsIgnoreCase(protocol.getName())) // GitHub Issue 763: case-insensitive name check + if (name.equalsIgnoreCase(protocol.getName())) // GitHub Issue 763: case-insensitive name check (https://github.com/LabKey/kanban/issues/763) return protocol; } } diff --git a/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql b/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql index 8976ddd30a0..6aed820ef70 100644 --- a/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql +++ b/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql @@ -1,2 +1,2 @@ ---GH Issue 778: materialinput Role can be a field name, which has a max length of 200 characters +--GH Issue 778: materialinput Role can be a field name, which has a max length of 200 characters (https://github.com/LabKey/kanban/issues/778) ALTER TABLE exp.MaterialInput ALTER COLUMN Role TYPE VARCHAR(200); \ No newline at end of file diff --git a/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql b/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql index 6a87381ad5a..f6d6f5fc498 100644 --- a/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql +++ b/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql @@ -1,4 +1,4 @@ ---GH Issue 778: materialinput Role can be a field name, which has a max length of 200 characters +--GH Issue 778: materialinput Role can be a field name, which has a max length of 200 characters (https://github.com/LabKey/kanban/issues/778) EXECUTE core.fn_dropifexists 'MaterialInput', 'exp', 'INDEX', 'IDX_MaterialInput_Role'; ALTER TABLE exp.MaterialInput ALTER COLUMN Role NVARCHAR(200) NOT NULL; CREATE INDEX IDX_MaterialInput_Role ON exp.MaterialInput(Role); \ No newline at end of file diff --git a/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java b/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java index a7512aafdea..dd7a89bef00 100644 --- a/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java +++ b/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java @@ -864,7 +864,7 @@ else if (newType.getJdbcType().isDateOrTime() && oldType.getJdbcType().isDateOrT { updateBooleanValue( new SQLFragment().appendIdentifier(_domain.getDomainKind().getStorageSchemaName()).append(".").appendIdentifier(_domain.getStorageTableName()), - _pd.getLegalSelectName(dialect), _pdOld.getFormat(), null); // GH Issue 755 + _pd.getLegalSelectName(dialect), _pdOld.getFormat(), null); // GH Issue 755 (https://github.com/LabKey/kanban/issues/755) } } else if (propResized) From 0992a31213913b7ac1787e2f5f89bab42aef011f Mon Sep 17 00:00:00 2001 From: cnathe Date: Tue, 18 Nov 2025 14:45:59 -0600 Subject: [PATCH 2/2] remap kanban issue number to internal-issues number --- assay/src/org/labkey/assay/AssayManager.java | 2 +- .../schemas/dbscripts/postgresql/exp-25.002-25.003.sql | 2 +- .../resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql | 2 +- .../org/labkey/experiment/api/property/DomainPropertyImpl.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/assay/src/org/labkey/assay/AssayManager.java b/assay/src/org/labkey/assay/AssayManager.java index a5cc9435b36..fd388acf34e 100644 --- a/assay/src/org/labkey/assay/AssayManager.java +++ b/assay/src/org/labkey/assay/AssayManager.java @@ -421,7 +421,7 @@ public AssaySchema createSchema(User user, Container container, @Nullable Contai List allProtocols = getAssayProtocols(container); for (ExpProtocol protocol : allProtocols) { - if (name.equalsIgnoreCase(protocol.getName())) // GitHub Issue 763: case-insensitive name check (https://github.com/LabKey/kanban/issues/763) + if (name.equalsIgnoreCase(protocol.getName())) // GitHub Issue #649: case-insensitive name check return protocol; } } diff --git a/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql b/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql index 6aed820ef70..bdf06f6e7fd 100644 --- a/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql +++ b/experiment/resources/schemas/dbscripts/postgresql/exp-25.002-25.003.sql @@ -1,2 +1,2 @@ ---GH Issue 778: materialinput Role can be a field name, which has a max length of 200 characters (https://github.com/LabKey/kanban/issues/778) +--GitHub Issue #652: materialinput Role can be a field name, which has a max length of 200 characters ALTER TABLE exp.MaterialInput ALTER COLUMN Role TYPE VARCHAR(200); \ No newline at end of file diff --git a/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql b/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql index f6d6f5fc498..b262d03a58e 100644 --- a/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql +++ b/experiment/resources/schemas/dbscripts/sqlserver/exp-25.002-25.003.sql @@ -1,4 +1,4 @@ ---GH Issue 778: materialinput Role can be a field name, which has a max length of 200 characters (https://github.com/LabKey/kanban/issues/778) +--GitHub Issue #652: materialinput Role can be a field name, which has a max length of 200 characters EXECUTE core.fn_dropifexists 'MaterialInput', 'exp', 'INDEX', 'IDX_MaterialInput_Role'; ALTER TABLE exp.MaterialInput ALTER COLUMN Role NVARCHAR(200) NOT NULL; CREATE INDEX IDX_MaterialInput_Role ON exp.MaterialInput(Role); \ No newline at end of file diff --git a/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java b/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java index dd7a89bef00..0c0a088aa0c 100644 --- a/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java +++ b/experiment/src/org/labkey/experiment/api/property/DomainPropertyImpl.java @@ -864,7 +864,7 @@ else if (newType.getJdbcType().isDateOrTime() && oldType.getJdbcType().isDateOrT { updateBooleanValue( new SQLFragment().appendIdentifier(_domain.getDomainKind().getStorageSchemaName()).append(".").appendIdentifier(_domain.getStorageTableName()), - _pd.getLegalSelectName(dialect), _pdOld.getFormat(), null); // GH Issue 755 (https://github.com/LabKey/kanban/issues/755) + _pd.getLegalSelectName(dialect), _pdOld.getFormat(), null); // GitHub Issue #647 } } else if (propResized)