From 33ce2934576261982b0c19f119d576b634c50c7e Mon Sep 17 00:00:00 2001 From: Lum Date: Thu, 28 Aug 2025 11:01:54 -0700 Subject: [PATCH 1/2] regression for 53630 --- .../test/tests/DataViewsReportOrderingTest.java | 11 +++++++++++ src/org/labkey/test/util/DataRegionTable.java | 10 ++++++++++ 2 files changed, 21 insertions(+) diff --git a/src/org/labkey/test/tests/DataViewsReportOrderingTest.java b/src/org/labkey/test/tests/DataViewsReportOrderingTest.java index bf6c17c243..e53a35a584 100644 --- a/src/org/labkey/test/tests/DataViewsReportOrderingTest.java +++ b/src/org/labkey/test/tests/DataViewsReportOrderingTest.java @@ -25,6 +25,8 @@ import org.labkey.test.TestTimeoutException; import org.labkey.test.categories.Daily; import org.labkey.test.components.ext4.Window; +import org.labkey.test.pages.reports.ManageViewsPage; +import org.labkey.test.pages.user.ShowUsersPage; import org.labkey.test.util.PortalHelper; import org.openqa.selenium.NoSuchElementException; import org.openqa.selenium.WebDriver; @@ -133,6 +135,15 @@ private String[] reverseReports(List reportsOriginalOrder) return reverseReports; } + @Test + public void testRootFolderAccess() + { + // Regression for issue 53630 + ShowUsersPage showUsersPage = goToSiteUsers(); + ManageViewsPage mvp = showUsersPage.getUsersTable().openManageViews(); + mvp.clickAddReport("R Report"); + } + @Override protected BrowserType bestBrowser() { diff --git a/src/org/labkey/test/util/DataRegionTable.java b/src/org/labkey/test/util/DataRegionTable.java index aacbb3d46d..24bd97645d 100644 --- a/src/org/labkey/test/util/DataRegionTable.java +++ b/src/org/labkey/test/util/DataRegionTable.java @@ -40,6 +40,7 @@ import org.labkey.test.pages.ImportDataPage; import org.labkey.test.pages.TimeChartWizard; import org.labkey.test.pages.query.UpdateQueryRowPage; +import org.labkey.test.pages.reports.ManageViewsPage; import org.labkey.test.params.FieldKey; import org.labkey.test.selenium.LazyWebElement; import org.labkey.test.selenium.RefindingWebElement; @@ -166,6 +167,15 @@ public CustomizeView openCustomizeGrid() return getCustomizeView(); } + public ManageViewsPage openManageViews() + { + if (!getCustomizeView().isPanelExpanded()) + { + getViewsMenu().clickSubMenu(false, "Manage Views"); + } + return new ManageViewsPage(getDriver()); + } + protected DataRegionExportHelper getExportPanel() { if (_exportHelper == null) From 8df435b4cd199398ba10c60a3b6511f2341570f8 Mon Sep 17 00:00:00 2001 From: Lum Date: Tue, 2 Sep 2025 10:37:10 -0700 Subject: [PATCH 2/2] code review feedback --- src/org/labkey/test/util/DataRegionTable.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/org/labkey/test/util/DataRegionTable.java b/src/org/labkey/test/util/DataRegionTable.java index 24bd97645d..26d73838ff 100644 --- a/src/org/labkey/test/util/DataRegionTable.java +++ b/src/org/labkey/test/util/DataRegionTable.java @@ -169,10 +169,7 @@ public CustomizeView openCustomizeGrid() public ManageViewsPage openManageViews() { - if (!getCustomizeView().isPanelExpanded()) - { - getViewsMenu().clickSubMenu(false, "Manage Views"); - } + getViewsMenu().clickSubMenu(false, "Manage Views"); return new ManageViewsPage(getDriver()); }