From d5af8a20eb9be9ef39eb944f008fc2d8ce5c1b6c Mon Sep 17 00:00:00 2001 From: cnathe Date: Tue, 18 Nov 2025 09:31:29 -0600 Subject: [PATCH 1/2] Add/update links for the GitHub issues in /kanban/issues --- src/org/labkey/test/tests/DomainDesignerTest.java | 4 ++-- src/org/labkey/test/tests/DomainFieldTypeChangeTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/org/labkey/test/tests/DomainDesignerTest.java b/src/org/labkey/test/tests/DomainDesignerTest.java index a8e2e78a7c..9b663e2deb 100644 --- a/src/org/labkey/test/tests/DomainDesignerTest.java +++ b/src/org/labkey/test/tests/DomainDesignerTest.java @@ -312,7 +312,7 @@ public void testInvalidLookupDomainField() throws IOException, CommandException domainDesignerPage.clickFinish(); } - @Test // GitHub Issue 788 + @Test // GitHub Issue 788 (https://github.com/LabKey/kanban/issues/788) public void testInvalidSampleFieldFromDelete() throws Exception { String listName = TestDataGenerator.randomDomainName("Sample Lookups List", DomainUtils.DomainKind.IntList); @@ -349,7 +349,7 @@ public void testInvalidSampleFieldFromDelete() throws Exception validateListSampleLookupField(editListDefinitionPage, st2SamplesField.getName(), sampleType2 + " Error: Invalid sample type", ""); } - @Test // GitHub Issue 788 + @Test // GitHub Issue 788 (https://github.com/LabKey/kanban/issues/788) public void testInvalidSampleFieldFromJSON() throws Exception { File jsonFile = TestFileUtils.getSampleData("lists/BadSampleFieldLookup.fields.json"); diff --git a/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java b/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java index d754c8ea91..4366514acd 100644 --- a/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java +++ b/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java @@ -68,7 +68,7 @@ public void testProvisionedDomainFieldChanges() throws IOException, CommandExcep FieldInfo integerField = FieldInfo.random("Test/Integer", FieldDefinition.ColumnType.Integer, DomainUtils.DomainKind.IntList); FieldInfo decimalField = FieldInfo.random("Test/Decimal", FieldDefinition.ColumnType.Decimal, DomainUtils.DomainKind.IntList); FieldInfo dateField = FieldInfo.random("Test/Date", FieldDefinition.ColumnType.DateAndTime, DomainUtils.DomainKind.IntList); - FieldInfo booleanField = FieldInfo.random("Test'/\"Boolean", FieldDefinition.ColumnType.Boolean, DomainUtils.DomainKind.IntList); // GH Issue #755 + FieldInfo booleanField = FieldInfo.random("Test'/\"Boolean", FieldDefinition.ColumnType.Boolean, DomainUtils.DomainKind.IntList); // GH Issue #755 (https://github.com/LabKey/kanban/issues/755) TestDataGenerator dgen = new TestDataGenerator("lists", listName, getProjectName()) .withColumns(List.of( stringField.getFieldDefinition(), @@ -117,7 +117,7 @@ public void testProvisionedDomainFieldChanges() throws IOException, CommandExcep domainFormPanel.getField(integerField.getName()).setType(FieldDefinition.ColumnType.String, true); domainFormPanel.getField(decimalField.getName()).setType(FieldDefinition.ColumnType.String, true); domainFormPanel.getField(dateField.getName()).setType(FieldDefinition.ColumnType.String, true); - domainFormPanel.getField(booleanField.getName()).setType(FieldDefinition.ColumnType.String, true); // GH Issue #755 + domainFormPanel.getField(booleanField.getName()).setType(FieldDefinition.ColumnType.String, true); // GH Issue #755 (https://github.com/LabKey/kanban/issues/755) domainDesignerPage.clickFinish(); clickAndWait(Locator.linkWithText(listName)); From 80a4e36a413b394cb2b400443bab538db02259ff Mon Sep 17 00:00:00 2001 From: cnathe Date: Tue, 18 Nov 2025 14:45:59 -0600 Subject: [PATCH 2/2] remap kanban issue number to internal-issues number --- src/org/labkey/test/tests/DomainDesignerTest.java | 4 ++-- src/org/labkey/test/tests/DomainFieldTypeChangeTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/org/labkey/test/tests/DomainDesignerTest.java b/src/org/labkey/test/tests/DomainDesignerTest.java index 9b663e2deb..5472642b86 100644 --- a/src/org/labkey/test/tests/DomainDesignerTest.java +++ b/src/org/labkey/test/tests/DomainDesignerTest.java @@ -312,7 +312,7 @@ public void testInvalidLookupDomainField() throws IOException, CommandException domainDesignerPage.clickFinish(); } - @Test // GitHub Issue 788 (https://github.com/LabKey/kanban/issues/788) + @Test // GitHub Issue #657 public void testInvalidSampleFieldFromDelete() throws Exception { String listName = TestDataGenerator.randomDomainName("Sample Lookups List", DomainUtils.DomainKind.IntList); @@ -349,7 +349,7 @@ public void testInvalidSampleFieldFromDelete() throws Exception validateListSampleLookupField(editListDefinitionPage, st2SamplesField.getName(), sampleType2 + " Error: Invalid sample type", ""); } - @Test // GitHub Issue 788 (https://github.com/LabKey/kanban/issues/788) + @Test // GitHub Issue #657 public void testInvalidSampleFieldFromJSON() throws Exception { File jsonFile = TestFileUtils.getSampleData("lists/BadSampleFieldLookup.fields.json"); diff --git a/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java b/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java index 4366514acd..edbb144b19 100644 --- a/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java +++ b/src/org/labkey/test/tests/DomainFieldTypeChangeTest.java @@ -68,7 +68,7 @@ public void testProvisionedDomainFieldChanges() throws IOException, CommandExcep FieldInfo integerField = FieldInfo.random("Test/Integer", FieldDefinition.ColumnType.Integer, DomainUtils.DomainKind.IntList); FieldInfo decimalField = FieldInfo.random("Test/Decimal", FieldDefinition.ColumnType.Decimal, DomainUtils.DomainKind.IntList); FieldInfo dateField = FieldInfo.random("Test/Date", FieldDefinition.ColumnType.DateAndTime, DomainUtils.DomainKind.IntList); - FieldInfo booleanField = FieldInfo.random("Test'/\"Boolean", FieldDefinition.ColumnType.Boolean, DomainUtils.DomainKind.IntList); // GH Issue #755 (https://github.com/LabKey/kanban/issues/755) + FieldInfo booleanField = FieldInfo.random("Test'/\"Boolean", FieldDefinition.ColumnType.Boolean, DomainUtils.DomainKind.IntList); // GitHub Issue #647 TestDataGenerator dgen = new TestDataGenerator("lists", listName, getProjectName()) .withColumns(List.of( stringField.getFieldDefinition(), @@ -117,7 +117,7 @@ public void testProvisionedDomainFieldChanges() throws IOException, CommandExcep domainFormPanel.getField(integerField.getName()).setType(FieldDefinition.ColumnType.String, true); domainFormPanel.getField(decimalField.getName()).setType(FieldDefinition.ColumnType.String, true); domainFormPanel.getField(dateField.getName()).setType(FieldDefinition.ColumnType.String, true); - domainFormPanel.getField(booleanField.getName()).setType(FieldDefinition.ColumnType.String, true); // GH Issue #755 (https://github.com/LabKey/kanban/issues/755) + domainFormPanel.getField(booleanField.getName()).setType(FieldDefinition.ColumnType.String, true); // GitHub Issue #647 domainDesignerPage.clickFinish(); clickAndWait(Locator.linkWithText(listName));