Skip to content

Add/update links for the GitHub issues in /kanban/issues #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 2 commits into from
Nov 19, 2025
Merged

Add/update links for the GitHub issues in /kanban/issues #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5af8a2
Add/update links for the GitHub issues in /kanban/issues
cnathe Nov 18, 2025
80a4e36
remap kanban issue number to internal-issues number
cnathe Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/org/labkey/test/tests/DomainDesignerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ public void testInvalidLookupDomainField() throws IOException, CommandException
domainDesignerPage.clickFinish();
}

@Test // GitHub Issue 788
@Test // GitHub Issue #657
public void testInvalidSampleFieldFromDelete() throws Exception
{
String listName = TestDataGenerator.randomDomainName("Sample Lookups List", DomainUtils.DomainKind.IntList);
Expand Down Expand Up @@ -349,7 +349,7 @@ public void testInvalidSampleFieldFromDelete() throws Exception
validateListSampleLookupField(editListDefinitionPage, st2SamplesField.getName(), sampleType2 + " Error: Invalid sample type", "<Invalid sample type: " + sampleType2 + ">");
}

@Test // GitHub Issue 788
@Test // GitHub Issue #657
public void testInvalidSampleFieldFromJSON() throws Exception
{
File jsonFile = TestFileUtils.getSampleData("lists/BadSampleFieldLookup.fields.json");
Expand Down
4 changes: 2 additions & 2 deletions src/org/labkey/test/tests/DomainFieldTypeChangeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public void testProvisionedDomainFieldChanges() throws IOException, CommandExcep
FieldInfo integerField = FieldInfo.random("Test/Integer", FieldDefinition.ColumnType.Integer, DomainUtils.DomainKind.IntList);
FieldInfo decimalField = FieldInfo.random("Test/Decimal", FieldDefinition.ColumnType.Decimal, DomainUtils.DomainKind.IntList);
FieldInfo dateField = FieldInfo.random("Test/Date", FieldDefinition.ColumnType.DateAndTime, DomainUtils.DomainKind.IntList);
FieldInfo booleanField = FieldInfo.random("Test'/\"Boolean", FieldDefinition.ColumnType.Boolean, DomainUtils.DomainKind.IntList); // GH Issue #755
FieldInfo booleanField = FieldInfo.random("Test'/\"Boolean", FieldDefinition.ColumnType.Boolean, DomainUtils.DomainKind.IntList); // GitHub Issue #647
TestDataGenerator dgen = new TestDataGenerator("lists", listName, getProjectName())
.withColumns(List.of(
stringField.getFieldDefinition(),
Expand Down Expand Up @@ -117,7 +117,7 @@ public void testProvisionedDomainFieldChanges() throws IOException, CommandExcep
domainFormPanel.getField(integerField.getName()).setType(FieldDefinition.ColumnType.String, true);
domainFormPanel.getField(decimalField.getName()).setType(FieldDefinition.ColumnType.String, true);
domainFormPanel.getField(dateField.getName()).setType(FieldDefinition.ColumnType.String, true);
domainFormPanel.getField(booleanField.getName()).setType(FieldDefinition.ColumnType.String, true); // GH Issue #755
domainFormPanel.getField(booleanField.getName()).setType(FieldDefinition.ColumnType.String, true); // GitHub Issue #647
domainDesignerPage.clickFinish();

clickAndWait(Locator.linkWithText(listName));
Expand Down
Loading