From a0878ac879e55c1563a2ea4c41ff763d91440fd7 Mon Sep 17 00:00:00 2001 From: Andreas Kremsler Date: Thu, 15 Jun 2023 17:12:25 +0200 Subject: [PATCH 1/5] $currentPage needs to be of type int --- src/Utils/SearchTranslationsUtils.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Utils/SearchTranslationsUtils.php b/src/Utils/SearchTranslationsUtils.php index f58083d..e83f30e 100644 --- a/src/Utils/SearchTranslationsUtils.php +++ b/src/Utils/SearchTranslationsUtils.php @@ -71,7 +71,7 @@ public function searchTranslationsFromRequest( } else { $pagerFanta->setMaxPerPage(50); } - $pagerFanta->setCurrentPage($request->query->get('page', 1)); + $pagerFanta->setCurrentPage((int) $request->query->get('page', 1)); return $pagerFanta; } From 06284512c7676a0fc37230f32cd77bc4afa59935 Mon Sep 17 00:00:00 2001 From: Andreas Kremsler Date: Tue, 23 Apr 2024 17:53:44 +0200 Subject: [PATCH 2/5] $currentPage needs to be of type int --- src/Utils/SearchTranslationsUtils.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Utils/SearchTranslationsUtils.php b/src/Utils/SearchTranslationsUtils.php index e83f30e..953264b 100644 --- a/src/Utils/SearchTranslationsUtils.php +++ b/src/Utils/SearchTranslationsUtils.php @@ -71,7 +71,7 @@ public function searchTranslationsFromRequest( } else { $pagerFanta->setMaxPerPage(50); } - $pagerFanta->setCurrentPage((int) $request->query->get('page', 1)); + $pagerFanta->setCurrentPage($request->query->getInt('page', 1)); return $pagerFanta; } From b1fa351684ea45da2fd139c29f3490eeacfa1dca Mon Sep 17 00:00:00 2001 From: Andreas Kremsler Date: Wed, 17 Sep 2025 14:54:54 +0200 Subject: [PATCH 3/5] allow symfony 7 --- composer.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/composer.json b/composer.json index 82cd7b6..4ace4b8 100644 --- a/composer.json +++ b/composer.json @@ -18,14 +18,14 @@ "php": ">=7.4 || >=8.1", "doctrine/doctrine-bundle": "^2.5", "doctrine/doctrine-migrations-bundle": "^3.2", - "symfony/console": "5.4.* || 6.*", - "symfony/http-kernel": "5.4.* || 6.*", - "symfony/property-access": "5.4.* || 6.*", - "symfony/translation": "5.4.* || 6.*", - "symfony/yaml": "5.4.* || 6.*", + "symfony/console": "5.4.* || 6.* || 7.*", + "symfony/http-kernel": "5.4.* || 6.* || 7.*", + "symfony/property-access": "5.4.* || 6.* || 7.*", + "symfony/translation": "5.4.* || 6.* || 7.*", + "symfony/yaml": "5.4.* || 6.* || 7.*", "twig/twig": "2.15.* || ^3.5", "pagerfanta/pagerfanta": "^2.6 || ^3.6 || ^4.0", - "symfony/form": "5.4.* || 6.*" + "symfony/form": "5.4.* || 6.* || 7.*" }, "prefer-stable": true, "autoload": { From 6fc31830a6f0eef7031129b25bcaf3ebaa767cb0 Mon Sep 17 00:00:00 2001 From: Andreas Kremsler Date: Fri, 19 Sep 2025 09:54:07 +0200 Subject: [PATCH 4/5] allow symfony 7 --- src/Cli/ExecuteMigrationCommand.php | 2 +- src/Cli/WriteTranslationValuesCommand.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Cli/ExecuteMigrationCommand.php b/src/Cli/ExecuteMigrationCommand.php index a1792a5..0c0202a 100644 --- a/src/Cli/ExecuteMigrationCommand.php +++ b/src/Cli/ExecuteMigrationCommand.php @@ -41,7 +41,7 @@ public function __construct( protected function configure(): void { - $this->setDescription('Execute migration of translations'); + $this->setName(self::$defaultName)->setDescription('Execute migration of translations'); $this->addOption( 'resync', diff --git a/src/Cli/WriteTranslationValuesCommand.php b/src/Cli/WriteTranslationValuesCommand.php index f05849f..049a4a9 100644 --- a/src/Cli/WriteTranslationValuesCommand.php +++ b/src/Cli/WriteTranslationValuesCommand.php @@ -49,7 +49,7 @@ public function __construct( protected function configure(): void { - $this->setDescription('Dump all translations into files'); + $this->setName(self::$defaultName)->setDescription('Dump all translations into files'); } protected function execute(InputInterface $input, OutputInterface $output): int From 122bfa3a9f7d89229c2811ef51c6f31938e688be Mon Sep 17 00:00:00 2001 From: Andreas Kremsler Date: Mon, 13 Oct 2025 12:46:08 +0200 Subject: [PATCH 5/5] allow symfony 7 --- src/Cli/ExecuteMigrationCommand.php | 2 +- src/Cli/WriteTranslationValuesCommand.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Cli/ExecuteMigrationCommand.php b/src/Cli/ExecuteMigrationCommand.php index 0c0202a..4e42a80 100644 --- a/src/Cli/ExecuteMigrationCommand.php +++ b/src/Cli/ExecuteMigrationCommand.php @@ -30,7 +30,7 @@ public function __construct( GlobFinder $translationFinder, string $translationMigrationDirectory, ExecutorInterface $migrationExecutor, - string $name = null + ?string $name = null ) { parent::__construct($name); diff --git a/src/Cli/WriteTranslationValuesCommand.php b/src/Cli/WriteTranslationValuesCommand.php index 049a4a9..cc62537 100644 --- a/src/Cli/WriteTranslationValuesCommand.php +++ b/src/Cli/WriteTranslationValuesCommand.php @@ -36,7 +36,7 @@ public function __construct( TranslationValueSaverInterface $translationValueSaver, string $localeCode, array $locales, - string $name = null + ?string $name = null ) { parent::__construct($name);