feat: add patch to convenient function

Author: MikeJerred

generate/input/libgit2-supplement.json

@@ -693,6 +693,19 @@
           "isErrorCode": true
         }
       },
+      "git_patch_to_convenient": {
+        "args": [],
+        "type": "function",
+        "isManual": true,
+        "cFile": "generate/templates/manual/patches/to_convenient.cc",
+        "isAsync": false,
+        "isPrototypeMethod": true,
+        "group": "patch",
+        "return": {
+          "type": "PatchData*",
+          "isErrorCode": false
+        }
+      },
       "git_path_is_gitfile": {
         "type": "function",
         "file": "sys/path.h",
@@ -1221,7 +1234,8 @@
       [
         "patch",
         [
-          "git_patch_convenient_from_diff"
+          "git_patch_convenient_from_diff",
+          "git_patch_to_convenient"
         ]
       ],
       [

generate/templates/manual/patches/to_convenient.cc

@@ -0,0 +1,33 @@
+NAN_METHOD(GitPatch::ToConvenient) {
+  Nan::EscapableHandleScope scope;
+
+  git_error_clear();
+
+  { // lock master scope start
+    nodegit::LockMaster lockMaster(
+      /*asyncAction: */false,
+      Nan::ObjectWrap::Unwrap<GitPatch>(info.This())->GetValue()
+    );
+
+    const PatchData * result = createFromRaw(
+      Nan::ObjectWrap::Unwrap<GitPatch>(info.This())->GetValue()
+    );
+
+    // null checks on pointers
+    if (!result) {
+      return info.GetReturnValue().Set(scope.Escape(Nan::Undefined()));
+    }
+
+    v8::Local<v8::Value> v8ConversionSlot;
+    // start convert_to_v8 block
+    if (result != NULL) {
+      v8ConversionSlot = ConvenientPatch::New((void *) result);
+    }
+    else {
+      v8ConversionSlot = Nan::Null();
+    }
+    // end convert_to_v8 block
+
+    return info.GetReturnValue().Set(scope.Escape(v8ConversionSlot));
+  }
+}

test/tests/patch.js

@@ -84,7 +84,7 @@ describe("Patch", function() {
   });
 
   it("can generate patch from blobs without 'old_blob'", function() {
-    // Generates a patch for README.md from commit 
+    // Generates a patch for README.md from commit
     // fce88902e66c72b5b93e75bdb5ae717038b221f6 without
     // old_blob. Should show all lines as additions.
     const file = "README.md";
@@ -106,4 +106,26 @@ describe("Patch", function() {
         assert.strictEqual(patch.size(0, 0, 0), 0);
       });
   });
+
+  it("can create convenient patch from patch", function() {
+    // Generates a patch for README.md from commit
+    // fce88902e66c72b5b93e75bdb5ae717038b221f6
+    const file = "README.md";
+
+    return NodeGit.Blob.lookup(
+      this.repository,
+      "b252f396b17661462372f78b7bcfc403b8731aaa"
+    ).then(blob => {
+      return NodeGit.Blob.lookup(
+        this.repository,
+        "b8d014998072c3f9e4b7eba8486011e80d8de98a"
+      ).then(oldBlob => {
+        return NodeGit.Patch.fromBlobs(oldBlob, file, blob, file)
+          .then(patch => {
+            var conv = patch.toConvenient();
+            assert.equal(conv.size(), patch.numHunks());
+          });
+        });
+    });
+  });
 });