Commit 6d13113
committed
Use metadata in 'bulk-update-embeddings'
Why these changes are being introduced:
* With TDA 3.8.0, we can now retrieve record metadata columns in
embeddings read methods. Filtering embeddings by `action="index"`
prevents any attempt to update documents that do not exist
in OpenSearch (`action="delete"`), which results in an API error..
This is important especially with the current state of tim.opensearch.bulk_update,
which will raise a BulkOperationError and cause the 'bulk_update_embeddings'
CLI command to exit early.
This also includes an additional change to also index embeddings
when performing a reindex.
How this addresses that need:
* Filter embeddings by action="index"
* Install latest version of timdex-dataset-api (latest commit)
* Update embeddings in fixtures/test/dataset to use 'embeddings_timestamp"
Side effects of this change:
* None
Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/USE-2731 parent fc4a958 commit 6d13113
File tree
4 files changed
+25
-7
lines changed- tests/fixtures/dataset/data/embeddings/year=2025/month=12/day=17
- tim
4 files changed
+25
-7
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
385 | 385 | | |
386 | 386 | | |
387 | 387 | | |
| 388 | + | |
388 | 389 | | |
389 | 390 | | |
390 | 391 | | |
| |||
454 | 455 | | |
455 | 456 | | |
456 | 457 | | |
457 | | - | |
458 | | - | |
459 | | - | |
| 458 | + | |
460 | 459 | | |
461 | 460 | | |
462 | 461 | | |
| 462 | + | |
463 | 463 | | |
464 | 464 | | |
465 | 465 | | |
| |||
468 | 468 | | |
469 | 469 | | |
470 | 470 | | |
471 | | - | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
472 | 490 | | |
473 | | - | |
| 491 | + | |
474 | 492 | | |
0 commit comments