From 68207a5b2494ffc2061b6f8fc24200f2cf024ad5 Mon Sep 17 00:00:00 2001 From: jennyhickson <61183013+jennyhickson@users.noreply.github.com> Date: Wed, 28 Jan 2026 11:55:31 +0000 Subject: [PATCH 1/6] first pass typing up --- .github/CODEOWNERS | 75 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index dbadb762..eb18ce43 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,73 @@ -**/jules_interface/rose-meta @maggiehendry -**/jedi_lfric* @ss421 @matthewrmshin -**/linear* @ss421 @matthewrmshin +# This CODEOWNERS file includes a primary codeowner and a deputy for each section. +# Codeowners who are not in a comment will be automatically notified of changes +# to the listed files. All codeowners listed are valid points of contact +# for discussing changes and seeking approval for work. + +# Applications +applications/adjoint_tests/ @DrTVockerodtMO # @mo-joshuacolclough +applications/gravity_wave/ @thomasmelvin # @cjohnson-pi +applications/gungho_model/ @thomasmelvin # @BShipway +applications/jedi_lfric_tests/ @ss421 @matthewrmshin # @DavidSimonin +applications/lfricinputs/ @mo-lottieturner # @mike-hobson +applications/lfric_atm/ # @iboutle # @BShipway +applications/lfric_coupled/ # @HengistPodd # @BShipway +applications/lfricinputs/ @mo-lottieturner # @mike-hobson +applications/linear_model/ @cjohnson-pi @ss421 @matthewrmshin # @tommbendall # Also notifiy jedi team about linear changes. +applications/name_transport/ @jameskent-metoffice # @tommbendall +applications/ngarch/ # @christophermaynard # @jcsmeto +applications/shallow_water/ @jameskent-metoffice # @atb1995 +applications/solver/ # @christophermaynard # @thomasmelvin +applications/transport/ # @tommbendall # @jameskent-metoffice + +# Science +science/adjoint/ @DrTVockerodtMO # @mo-joshuacolclough +science/constants/ # @iboutle # @BShipway +science/linear/ @cjohnson-pi @ss421 @matthewrmshin # @tommbendall # Also notifiy jedi team about linear changes. + +science/gungho/ @thomasmelvin # @iboutle +science/gungho/source/algorithm/core_dynamics/ @jameskent-metoffice # @thomasmelvin +science/gungho/source/algorithm/diagnostics/ @atb1995 # @iboutle +science/gungho/source/algorithm/diffusion/ @iboutle # @tommbendall +science/gungho/source/algorithm/initialisation/ # Chris smith # @thomasmelvin +science/gungho/source/algorithm/limited_area/ @cjohnson-pi # @thomasmelvin +science/gungho/source/algorithm/physics/ @iboutle # @tommbendall +science/gungho/source/algorithm/runtime_constants/ @tommbendall # @atb1995 +science/gungho/source/algorithm/solver/ @thomasmelvin # @tommbendall +science/gungho/source/algorithm/timestepping/ @thomasmelvin # @jameskent-metoffice +science/gungho/source/algorithm/transport/ @tommbendall # @jameskent-metoffice +science/gungho/source/configuration/ @jameskent-metoffice # @thomasmelvin +science/gungho/source/driver/ #? # @iboutle +science/gungho/source/orography/ @atb1995 # @tommbendall +science/gungho/source/psy/ @thomasmelvin # @tommbendall + +science/physics_schemes/ # @iboutle # @MetOffice/ssdteam +science/physics_schemes/source/boundary_layer @Adrian-Lock # @P-Burns +science/physics_schemes/source/convection @MichaelWhitall +science/physics_schemes/source/comorph @MichaelWhitall +science/physics_schemes/source/large_scale_cloud @paul-barrett # @CyrilMorcrette +science/physics_schemes/source/large_scale_precipitation @paulfield2024 # @paul-barrett +science/physics_schemes/source/radiation_control @mo-jmanners # @Petzi1 +science/physics_schemes/source/stochastic_physics @wjtmo # @annemccabe + +# Interfaces +interfaces/coupled_interface/ # @mike-hobson # @harry-shepherd +interfaces/jedi_lfric_interface/ @ss421 @matthewrmshin # @DavidSimonin +interfaces/jules_interface/ # @iboutle # @MetOffice/ssdteam +interfaces/jules_interface/rose-meta @maggiehendry +interfaces/physics_schemes_interface/ # @iboutle # @MetOffice/ssdteam +interfaces/socrates_interface/ @mo-jmanners # @Petzi1 + +# System Components +/rose-stem/templates/ @james-bruten-mo # @jennyhickson +**/versions.py @james-bruten-mo # @jennyhickson +build/ @MetOffice/ssdteam +**/*Makefile # @MatthewHambley +**/*.mk # @MatthewHambley + +# Other areas +documentation # @MetOffice/ssdteam +.github/ @MetOffice/ssdteam +LICENSE @yaswant +README.md @MetOffice/ssdteam + From ebdec3044a04684a595fcfe11bac70b3cc0924cf Mon Sep 17 00:00:00 2001 From: jennyhickson <61183013+jennyhickson@users.noreply.github.com> Date: Wed, 28 Jan 2026 11:56:37 +0000 Subject: [PATCH 2/6] correct comorph path --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index eb18ce43..99eda8f6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -43,7 +43,7 @@ science/gungho/source/psy/ @thomasmelvin science/physics_schemes/ # @iboutle # @MetOffice/ssdteam science/physics_schemes/source/boundary_layer @Adrian-Lock # @P-Burns science/physics_schemes/source/convection @MichaelWhitall -science/physics_schemes/source/comorph @MichaelWhitall +science/physics_schemes/source/convection/comorph @MichaelWhitall science/physics_schemes/source/large_scale_cloud @paul-barrett # @CyrilMorcrette science/physics_schemes/source/large_scale_precipitation @paulfield2024 # @paul-barrett science/physics_schemes/source/radiation_control @mo-jmanners # @Petzi1 From 7c6b1aabe5e5d109cc9afe4f6374b57da4e83b52 Mon Sep 17 00:00:00 2001 From: jennyhickson <61183013+jennyhickson@users.noreply.github.com> Date: Wed, 28 Jan 2026 11:58:08 +0000 Subject: [PATCH 3/6] add jules app --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 99eda8f6..a342bc84 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,6 +8,7 @@ applications/adjoint_tests/ @DrTVockerodtMO # @m applications/gravity_wave/ @thomasmelvin # @cjohnson-pi applications/gungho_model/ @thomasmelvin # @BShipway applications/jedi_lfric_tests/ @ss421 @matthewrmshin # @DavidSimonin +application/jules/ @iboutle # @MetOffice/ssdtesam applications/lfricinputs/ @mo-lottieturner # @mike-hobson applications/lfric_atm/ # @iboutle # @BShipway applications/lfric_coupled/ # @HengistPodd # @BShipway From 7d71ca57c3e9a7baf029e49a0acf5f02b32221bb Mon Sep 17 00:00:00 2001 From: jennyhickson <61183013+jennyhickson@users.noreply.github.com> Date: Wed, 28 Jan 2026 12:20:37 +0000 Subject: [PATCH 4/6] fix jules --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a342bc84..404abaea 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,7 +8,7 @@ applications/adjoint_tests/ @DrTVockerodtMO # @m applications/gravity_wave/ @thomasmelvin # @cjohnson-pi applications/gungho_model/ @thomasmelvin # @BShipway applications/jedi_lfric_tests/ @ss421 @matthewrmshin # @DavidSimonin -application/jules/ @iboutle # @MetOffice/ssdtesam +applications/jules/ # @iboutle # @MetOffice/ssdtesam applications/lfricinputs/ @mo-lottieturner # @mike-hobson applications/lfric_atm/ # @iboutle # @BShipway applications/lfric_coupled/ # @HengistPodd # @BShipway From a34f7ec0fc9bdaa3093b041b751f4c308e32ee70 Mon Sep 17 00:00:00 2001 From: jennyhickson <61183013+jennyhickson@users.noreply.github.com> Date: Wed, 28 Jan 2026 12:26:40 +0000 Subject: [PATCH 5/6] remove old file --- CodeOwners.txt | 54 -------------------------------------------------- 1 file changed, 54 deletions(-) delete mode 100644 CodeOwners.txt diff --git a/CodeOwners.txt b/CodeOwners.txt deleted file mode 100644 index 36b0e987..00000000 --- a/CodeOwners.txt +++ /dev/null @@ -1,54 +0,0 @@ -= Code Owners = - -This file lists ownership of the major components in the LFRic Apps codebase. - -* Ownership is not a commitment for the individual to undertake all work - requested or all reviewing for the owned section. -* Any planned changes to a section should be discussed with the code owner to - ensure all plans are appropriate. -* Code owners should be given the option to be a science/technical reviewer - for any code that alters their sections. - -Contact details for code owners: https://code.metoffice.gov.uk/trac/home/wiki/UserList - -# Start of script readable lines - -= System Components = -{{{ -Area First Contact Second Contact Team -rose-stem jamesbruten jenniferhickson simulation_systems_and_deployment -build umsysteam@metoffice.gov.uk -- simulation_systems_and_deployment -Makefiles matthewhambley -- core_capability_development -}}} - -= Applications = -{{{ -Area First Contact Second Contact Team -adjoint_tests terencevockerodt joshuacolclough data_assimilation -gravity_wave thomasmelvin christinejohnson dynamics_research -gungho_model thomasmelvin benshipway dynamics_research -jedi_lfric_tests stevensandbach davidsimonin data_assimilation -lfric_atm ianboutle benshipway dynamics_research -lfric_coupled richardhill benshipway global_coupled_model_development -lfricinputs charlotteturner mikehobson core_capability_development -linear_model christinejohnson thomasbendall dynamics_research -name_transport jameskent thomasbendall dynamics_research -ngarch christophermaynard jamescunningham-smith ng-arch -shallow_water jameskent alexbrown dynamics_research -solver christophermaynard thomasmelvin ng-opt -transport thomasbendall jameskent dynamics_research -}}} - -= Science = -{{{ -Area First Contact Second Contact Team -adjoint terencevockerodt joshuacolclough data_assimilation -constants ianboutle benshipway dynamics_research -coupled_interface mikehobson jeanrioual -- -gungho thomasmelvin benshipway dynamics_research -jedi_lfric_interface stevensandbach davidsimonin data_assimilation -jules_interface ianboutle richardgilham atmospheric_processes_and_parametrizations -linear christinejohnson thomasbendall dynamics_research -socrates_interface jamesmanners stephanhavemann radiation -physics_schemes_interface ianboutle https://code.metoffice.gov.uk/trac/um/browser/main/trunk/CodeOwners.txt simulation_systems_and_deployment -}}} From a8d9b406510d75f78a8b6a93d111ee9f860ef634 Mon Sep 17 00:00:00 2001 From: jennyhickson <61183013+jennyhickson@users.noreply.github.com> Date: Wed, 28 Jan 2026 14:27:44 +0000 Subject: [PATCH 6/6] correct gungho --- .github/CODEOWNERS | 65 +++++++++++++++++++++++----------------------- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 404abaea..ea1ba743 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -18,49 +18,50 @@ applications/name_transport/ @jameskent-metoffice # @t applications/ngarch/ # @christophermaynard # @jcsmeto applications/shallow_water/ @jameskent-metoffice # @atb1995 applications/solver/ # @christophermaynard # @thomasmelvin -applications/transport/ # @tommbendall # @jameskent-metoffice +applications/transport/ @tommbendall # @jameskent-metoffice # Science science/adjoint/ @DrTVockerodtMO # @mo-joshuacolclough -science/constants/ # @iboutle # @BShipway science/linear/ @cjohnson-pi @ss421 @matthewrmshin # @tommbendall # Also notifiy jedi team about linear changes. +science/shared/source/constants/ # @iboutle # @BShipway -science/gungho/ @thomasmelvin # @iboutle -science/gungho/source/algorithm/core_dynamics/ @jameskent-metoffice # @thomasmelvin -science/gungho/source/algorithm/diagnostics/ @atb1995 # @iboutle -science/gungho/source/algorithm/diffusion/ @iboutle # @tommbendall -science/gungho/source/algorithm/initialisation/ # Chris smith # @thomasmelvin -science/gungho/source/algorithm/limited_area/ @cjohnson-pi # @thomasmelvin -science/gungho/source/algorithm/physics/ @iboutle # @tommbendall -science/gungho/source/algorithm/runtime_constants/ @tommbendall # @atb1995 -science/gungho/source/algorithm/solver/ @thomasmelvin # @tommbendall -science/gungho/source/algorithm/timestepping/ @thomasmelvin # @jameskent-metoffice -science/gungho/source/algorithm/transport/ @tommbendall # @jameskent-metoffice -science/gungho/source/configuration/ @jameskent-metoffice # @thomasmelvin -science/gungho/source/driver/ #? # @iboutle -science/gungho/source/orography/ @atb1995 # @tommbendall -science/gungho/source/psy/ @thomasmelvin # @tommbendall +science/gungho/ @thomasmelvin # @iboutle +science/gungho/**/configuration/ @jameskent-metoffice # @thomasmelvin +science/gungho/**/core_dynamics/ @jameskent-metoffice # @thomasmelvin +science/gungho/**/diagnostics/ @atb1995 # @iboutle +science/gungho/**/diffusion/ @iboutle # @tommbendall +science/gungho/**/driver/ #? # @iboutle +science/gungho/**/external_forcing/ @iboutle # @tommbendall +science/gungho/**/initialisation/ # Chris smith # @thomasmelvin +science/gungho/**/limited_area/ @cjohnson-pi # @thomasmelvin +science/gungho/**/orography/ @atb1995 # @tommbendall +science/gungho/**/physics/ @iboutle # @tommbendall +science/gungho/**/psy/ @thomasmelvin # @tommbendall +science/gungho/**/runtime_constants/ @tommbendall # @atb1995 +science/gungho/**/solver/ @thomasmelvin # @tommbendall +science/gungho/**/timestepping/ @thomasmelvin # @jameskent-metoffice +science/gungho/**/transport/ @tommbendall # @jameskent-metoffice -science/physics_schemes/ # @iboutle # @MetOffice/ssdteam -science/physics_schemes/source/boundary_layer @Adrian-Lock # @P-Burns -science/physics_schemes/source/convection @MichaelWhitall -science/physics_schemes/source/convection/comorph @MichaelWhitall -science/physics_schemes/source/large_scale_cloud @paul-barrett # @CyrilMorcrette -science/physics_schemes/source/large_scale_precipitation @paulfield2024 # @paul-barrett -science/physics_schemes/source/radiation_control @mo-jmanners # @Petzi1 -science/physics_schemes/source/stochastic_physics @wjtmo # @annemccabe +science/physics_schemes/ # @iboutle # @MetOffice/ssdteam +science/physics_schemes/**/boundary_layer @Adrian-Lock # @P-Burns +science/physics_schemes/**/convection @MichaelWhitall +science/physics_schemes/**/convection/comorph @MichaelWhitall +science/physics_schemes/**/large_scale_cloud @paul-barrett # @CyrilMorcrette +science/physics_schemes/**/large_scale_precipitation @paulfield2024 # @paul-barrett +science/physics_schemes/**/radiation_control @mo-jmanners # @Petzi1 +science/physics_schemes/**/stochastic_physics @wjtmo # @annemccabe # Interfaces -interfaces/coupled_interface/ # @mike-hobson # @harry-shepherd -interfaces/jedi_lfric_interface/ @ss421 @matthewrmshin # @DavidSimonin -interfaces/jules_interface/ # @iboutle # @MetOffice/ssdteam +interfaces/coupled_interface/ @mike-hobson # @harry-shepherd +interfaces/jedi_lfric_interface/ @ss421 @matthewrmshin # @DavidSimonin +interfaces/jules_interface/ # @iboutle # @MetOffice/ssdteam interfaces/jules_interface/rose-meta @maggiehendry -interfaces/physics_schemes_interface/ # @iboutle # @MetOffice/ssdteam -interfaces/socrates_interface/ @mo-jmanners # @Petzi1 +interfaces/physics_schemes_interface/ # @iboutle # @MetOffice/ssdteam +interfaces/socrates_interface/ @mo-jmanners # @Petzi1 # System Components -/rose-stem/templates/ @james-bruten-mo # @jennyhickson -**/versions.py @james-bruten-mo # @jennyhickson +/rose-stem/templates/ @james-bruten-mo # @jennyhickson +**/versions.py @james-bruten-mo # @jennyhickson build/ @MetOffice/ssdteam **/*Makefile # @MatthewHambley **/*.mk # @MatthewHambley