fix(transaction-controller): use provided batchId in hook batches #7705
+79
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
addTransactionBatchWithHookfunction in theTransactionControllerwas always generating a newbatchId, even when abatchIdwas explicitly provided in theuserRequest. This meant that the providedbatchIdwas ignored when processing a batch through the publish batch hook route.This change modifies
addTransactionBatchWithHookto check for abatchIdin theuserRequest(viabatchIdOverride) and use it if present. If nobatchIdis provided, it falls back to generating a new one, aligning its behavior withaddTransactionBatchWith7702.No.
References
Checklist
Note
Fix: batch ID propagation in hook path
addTransactionBatch(hook route) now usesrequest.batchIdif provided, falling back to a generated ID (batch.ts)batchIdand propagation to nestedaddTransactioncalls when usingpublishBatchHook(batch.test.ts)Written by Cursor Bugbot for commit 84c0534. This will update automatically on new commits. Configure here.