From e8d5d6c3d17f4245392389f4b40ea7933e8b9d8d Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 7 Feb 2026 21:06:41 +0000 Subject: [PATCH] feat: improve domain search accessibility and input handling - switch from `on:keyup` to `on:input` for more robust search triggering - use `ReturnType` for correct timer typing - add `aria-label` to loading spinner - wrap search results in `role="status"` region for screen reader announcements Co-authored-by: Yeboster <23556525+Yeboster@users.noreply.github.com> --- .github/dependabot.yml | 6 +- .jules/palette.md | 3 + src/components/DomainPayment.svelte | 8 ++- src/components/LoadingButton.svelte | 2 +- src/components/Record.svelte | 14 +++- src/lib/sdk.ts | 2 +- src/lib/server/index.ts | 1 - src/lib/types.ts | 8 +-- src/lib/url.ts | 9 ++- src/routes/+layout.svelte | 1 - src/routes/DomainSearch.svelte | 64 ++++++++++--------- .../register/[name]/fees/[coin]/+server.ts | 19 +++--- src/routes/profile/+page.svelte | 1 - src/styles/mixins.scss | 2 +- src/theme/dark/_smui-theme.scss | 2 +- 15 files changed, 81 insertions(+), 61 deletions(-) create mode 100644 .jules/palette.md diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 42adb44..301e978 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -5,7 +5,7 @@ version: 2 updates: - - package-ecosystem: "npm" - directory: "/" + - package-ecosystem: 'npm' + directory: '/' schedule: - interval: "weekly" + interval: 'weekly' diff --git a/.jules/palette.md b/.jules/palette.md new file mode 100644 index 0000000..05a3f1f --- /dev/null +++ b/.jules/palette.md @@ -0,0 +1,3 @@ +## 2024-10-27 - Search Input Accessibility +**Learning:** The `@smui/textfield` component relies on `on:keyup` in existing patterns, which misses non-keyboard inputs like paste. Using `on:input` is more robust. Also, `@smui/circular-progress` lacks default accessibility labels. +**Action:** When implementing search or text inputs, prefer `on:input`. Always add `aria-label` to loading indicators. diff --git a/src/components/DomainPayment.svelte b/src/components/DomainPayment.svelte index ac131ee..e04970d 100644 --- a/src/components/DomainPayment.svelte +++ b/src/components/DomainPayment.svelte @@ -102,7 +102,11 @@

{domainName}

- addYears(-1)} disabled={years === 1 || feesApproved} aria-label="remove-year"> + addYears(-1)} + disabled={years === 1 || feesApproved} + aria-label="remove-year" + > {years} {yearsLabel} @@ -111,7 +115,7 @@
-
+

Payment token