-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Rough workflow to Incorporate Jacqui’s Edge Dry Spot Detection into SpotSweeper.
The overall idea here is that we frequently observe edge dry spot artifacts in Visium due to incomplete reagent spread. Jacqui has developed a nice workflow that takes this edge knowledge into account to accurately detect these artifacts. So we now want to include this function into SpotSweeper.
Harriet He will be taking the lead on this.
Preparation & Initial Setup
-
Obtain Jacqui’s existing code/functions.
-
Identify appropriate Visium samples for testing (@MicTott for help).
- Select at least two representative Visium arrays:
- Positive case (clear edge artifacts).
- Negative control (clean edges).
- Select at least two representative Visium arrays:
Development & Branching Strategy (Git Workflow)
-
Set up a new branch for feature development.
git checkout -b feature/edge-dry-spot-detection git push -u origin feature/edge-dry-spot-detection
-
Incorporate Jacqui’s functions into SpotSweeper.
- Document functions clearly (inline comments, roxygen).
-
Run local checks.
BiocCheck::BiocCheck(".")
devtools::check()Validation & Testing
-
Validate functions.
- Test with selected samples.
- Visualize via spatial plots fo validation.
-
Write unit tests (using testthat).
- Test for output validation.
tests/testthat/test-edge-dry-spots.R
Documentation & Versioning
-
Update documentation.
- Update README, NEWS.md clearly highlighting new feature.
- Create new Vignette showing off the function.
-
Increment SpotSweeper version number (semantic versioning).
Code Review & Merge
- Open a Pull Request (PR).
- Review by @MicTott and Jacqui.
- Merge into main after approval (@MicTott) .
- Push updates to GitHub/Bioconductor.
- Tag release:
git tag -a v1.4.0 -m "Release v1.4.0: Added edge dry spot detection"
git push --tags