Skip to content

[Feature Request] Edge dry spot detection #22

@MicTott

Description

@MicTott

Rough workflow to Incorporate Jacqui’s Edge Dry Spot Detection into SpotSweeper.

The overall idea here is that we frequently observe edge dry spot artifacts in Visium due to incomplete reagent spread. Jacqui has developed a nice workflow that takes this edge knowledge into account to accurately detect these artifacts. So we now want to include this function into SpotSweeper.

Harriet He will be taking the lead on this.


Preparation & Initial Setup

  1. Obtain Jacqui’s existing code/functions.

  2. Identify appropriate Visium samples for testing (@MicTott for help).

    • Select at least two representative Visium arrays:
      • Positive case (clear edge artifacts).
      • Negative control (clean edges).

Development & Branching Strategy (Git Workflow)

  1. Set up a new branch for feature development.

    git checkout -b feature/edge-dry-spot-detection
    git push -u origin feature/edge-dry-spot-detection
  2. Incorporate Jacqui’s functions into SpotSweeper.

    • Document functions clearly (inline comments, roxygen).
  3. Run local checks.

BiocCheck::BiocCheck(".")
devtools::check()

Validation & Testing

  1. Validate functions.

    • Test with selected samples.
    • Visualize via spatial plots fo validation.
  2. Write unit tests (using testthat).

    • Test for output validation.
    tests/testthat/test-edge-dry-spots.R
    

Documentation & Versioning

  1. Update documentation.

    • Update README, NEWS.md clearly highlighting new feature.
    • Create new Vignette showing off the function.
  2. Increment SpotSweeper version number (semantic versioning).


Code Review & Merge

  1. Open a Pull Request (PR).
  1. Merge into main after approval (@MicTott) .

  1. Push updates to GitHub/Bioconductor.
  • Tag release:
git tag -a v1.4.0 -m "Release v1.4.0: Added edge dry spot detection"
git push --tags

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions