Removing 'PORT=[port #]' instances to improve interoperability with Windows #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

richardcarrigan wants to merge 12 commits into MoonHighway:main from richardcarrigan:patch-1

gateway-hue-review/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=4000 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

service-accounts/index.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -115,7 +115,7 @@ async function startApolloServer() { @@
             verifyPassword,
           };
         },
-        listen: { port: process.env.PORT },
+        listen: { port: 4001 },
       });
       console.log(`👨‍👩‍👦‍👦 Accounts service running at ${url}`);
     }
@@ Expand Down @@

service-accounts/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "Let' build an account service",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=4001 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

service-colors/index.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -45,7 +45,7 @@ async function startApolloServer() { @@
           addColor,
           findColor,
         }),
-        listen: { port: process.env.PORT },
+        listen: { port: 4002 },
       });
       console.log(`colors service running at: ${url}`);
     }
@@ Expand Down @@

service-colors/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "A service to manage all of the colors posted to the hue-review.",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=4002 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

service-reviews/index.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ const start = async () => { @@
           };
         }
       });
-      server.listen(process.env.PORT).then(({ url }) => {
+      server.listen(4003).then(({ url }) => {
         console.log(
           `⭐️ ⭐️ ⭐️ ⭐️ ⭐️  - Review service running at: ${url}`
         );
@@ Expand Down @@

service-reviews/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "A service to reviews and comments for all users across multiple applications.",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=4003 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

snowtooth/gateway/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=5000 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

snowtooth/lifts/index.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -59,7 +59,7 @@ const resolvers = { @@
     async function startApolloServer() {
       const server = new ApolloServer({ typeDefs, resolvers });
       const { url } = await startStandaloneServer(server, {
-        listen: { port: process.env.PORT },
+        listen: { port: 5001 },
       });
       console.log(`🚡 Lift Server ready at ${url}`);
     }
@@ Expand Down @@

snowtooth/lifts/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=5001 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

snowtooth/trails/index.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -66,7 +66,7 @@ const resolvers = { @@
     async function startApolloServer() {
       const server = new ApolloServer({ typeDefs, resolvers });
       const { url } = await startStandaloneServer(server, {
-        listen: { port: process.env.PORT },
+        listen: { port: 5002 },
       });
       console.log(
         `🏔 Snowtooth - trail Service running at ${url}`
@@ Expand Down @@

snowtooth/trails/package.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
       "description": "",
       "main": "index.js",
       "scripts": {
-        "start": "PORT=5002 nodemon ."
+        "start": "nodemon ."
       },
       "keywords": [],
       "author": "",
@@ Expand Down @@

Provide feedback