From 88056a82979d8aadddd219e173ada24fe247a032 Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Mon, 22 Sep 2025 11:50:44 -0400 Subject: [PATCH 1/7] Disable SSL for testing database We've had some certificate errors when testing. Since this is a temporary database that's thrown out after tests are over and contain no significant data, it's safe to use an unencrypted connection. --- .github/workflows/unit_tests.yml | 4 ++-- bin/install-wp-tests.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 0bbceec..05025ee 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -33,7 +33,7 @@ jobs: env: MYSQL_DATABASE: wordpress_test MYSQL_ROOT_PASSWORD: root - options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 + options: --ssl-mode=DISABLED --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 steps: - uses: actions/checkout@v4 @@ -65,7 +65,7 @@ jobs: - name: Install WP test suite run: | - mysql -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" + mysql --ssl-mode=DISABLED -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" bash ./bin/install-wp-tests.sh wordpress_test root 'root' mysql ${{ matrix.wp-version }} - name: Run PHPUnit with coverage diff --git a/bin/install-wp-tests.sh b/bin/install-wp-tests.sh index c6f53dc..3a5e7cb 100755 --- a/bin/install-wp-tests.sh +++ b/bin/install-wp-tests.sh @@ -166,7 +166,7 @@ install_db() { fi # create database - if [ $(mysql --user="$DB_USER" --password="$DB_PASS"$EXTRA --execute='show databases;' | grep ^$DB_NAME$) ] + if [ $(mysql --ssl-mode=DISABLED --user="$DB_USER" --password="$DB_PASS"$EXTRA --execute='show databases;' | grep ^$DB_NAME$) ] then echo "Reinstalling will delete the existing test database ($DB_NAME)" read -p 'Are you sure you want to proceed? [y/N]: ' DELETE_EXISTING_DB From 0b0580d47f19ae2f68c48712ef890d233e64156b Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Mon, 22 Sep 2025 11:52:12 -0400 Subject: [PATCH 2/7] Remove ssl mode from docker service --- .github/workflows/unit_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 05025ee..d21d993 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -33,7 +33,7 @@ jobs: env: MYSQL_DATABASE: wordpress_test MYSQL_ROOT_PASSWORD: root - options: --ssl-mode=DISABLED --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 + options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 steps: - uses: actions/checkout@v4 From dc3ca16563b4cc45adb998527c5af0e13830e2e2 Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Tue, 23 Sep 2025 14:19:23 -0400 Subject: [PATCH 3/7] Reset unit test job --- .github/workflows/unit_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index d21d993..102e4b6 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -65,7 +65,7 @@ jobs: - name: Install WP test suite run: | - mysql --ssl-mode=DISABLED -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" + mysql -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" bash ./bin/install-wp-tests.sh wordpress_test root 'root' mysql ${{ matrix.wp-version }} - name: Run PHPUnit with coverage From 83c98e8c3f61af054db841e40ddd55f82099f99d Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Tue, 23 Sep 2025 17:19:23 -0400 Subject: [PATCH 4/7] SSL flag --- .github/workflows/unit_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 102e4b6..d21d993 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -65,7 +65,7 @@ jobs: - name: Install WP test suite run: | - mysql -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" + mysql --ssl-mode=DISABLED -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" bash ./bin/install-wp-tests.sh wordpress_test root 'root' mysql ${{ matrix.wp-version }} - name: Run PHPUnit with coverage From 507811d6b1620e10f397ed0aad807012e42fff50 Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Tue, 23 Sep 2025 17:40:26 -0400 Subject: [PATCH 5/7] Wrong command? --- .github/workflows/unit_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index d21d993..d93455d 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -65,7 +65,7 @@ jobs: - name: Install WP test suite run: | - mysql --ssl-mode=DISABLED -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" + mysql --skip-ssl -u root -proot -h mysql -P 3306 -e "DROP DATABASE IF EXISTS wordpress_test;" bash ./bin/install-wp-tests.sh wordpress_test root 'root' mysql ${{ matrix.wp-version }} - name: Run PHPUnit with coverage From 2e418b3cb234a73c560d9001ba34e5b4ca24105d Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Tue, 23 Sep 2025 17:44:37 -0400 Subject: [PATCH 6/7] Fixes the command --- bin/install-wp-tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/install-wp-tests.sh b/bin/install-wp-tests.sh index 3a5e7cb..5a5da41 100755 --- a/bin/install-wp-tests.sh +++ b/bin/install-wp-tests.sh @@ -166,7 +166,7 @@ install_db() { fi # create database - if [ $(mysql --ssl-mode=DISABLED --user="$DB_USER" --password="$DB_PASS"$EXTRA --execute='show databases;' | grep ^$DB_NAME$) ] + if [ $(mysql --skip-ssl --user="$DB_USER" --password="$DB_PASS"$EXTRA --execute='show databases;' | grep ^$DB_NAME$) ] then echo "Reinstalling will delete the existing test database ($DB_NAME)" read -p 'Are you sure you want to proceed? [y/N]: ' DELETE_EXISTING_DB From 1b9f2f5b51a15e17487919b6246bf5e47694e4f5 Mon Sep 17 00:00:00 2001 From: Allan Lasser Date: Tue, 23 Sep 2025 19:00:20 -0400 Subject: [PATCH 7/7] One more --- bin/install-wp-tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/install-wp-tests.sh b/bin/install-wp-tests.sh index 5a5da41..374ca78 100755 --- a/bin/install-wp-tests.sh +++ b/bin/install-wp-tests.sh @@ -130,7 +130,7 @@ recreate_db() { shopt -s nocasematch if [[ $1 =~ ^(y|yes)$ ]] then - mysqladmin drop $DB_NAME -f --user="$DB_USER" --password="$DB_PASS"$EXTRA + mysqladmin drop $DB_NAME -f --skip-ssl --user="$DB_USER" --password="$DB_PASS"$EXTRA create_db echo "Recreated the database ($DB_NAME)." else @@ -140,7 +140,7 @@ recreate_db() { } create_db() { - mysqladmin create $DB_NAME --user="$DB_USER" --password="$DB_PASS"$EXTRA + mysqladmin create $DB_NAME --skip-ssl --user="$DB_USER" --password="$DB_PASS"$EXTRA } install_db() {